fix(cli/self-update): postpone initialization of Cfg in setup_mode - #4996
Draft
rami3l wants to merge 3 commits into
Draft
fix(cli/self-update): postpone initialization of Cfg in setup_mode#4996rami3l wants to merge 3 commits into
setup_mode#4996rami3l wants to merge 3 commits into
Conversation
rami3l
force-pushed
the
fix/early-cfg-creation
branch
from
August 4, 2026 14:46
789aac3 to
eab7dbc
Compare
rami3l
force-pushed
the
fix/early-cfg-creation
branch
from
August 4, 2026 14:48
eab7dbc to
60aa826
Compare
rami3l
force-pushed
the
fix/early-cfg-creation
branch
from
August 4, 2026 15:10
60aa826 to
51b18cf
Compare
rami3l
commented
Aug 4, 2026
| warn!("{}", settings_file_path.display()); | ||
| let inferred = PartialToolchainDesc::from_str("stable")?.resolve(&cfg.default_host_tuple()?)?; | ||
| warn!("{}", settings_file.path.display()); | ||
| let default_host_tuple = settings_file.with(|s| Ok(default_host_tuple(s, process)))?; |
Member
Author
There was a problem hiding this comment.
This line is essentially the same as Cfg::default_host_tuple(), should we extract it somehow?
rami3l
commented
Aug 4, 2026
| @@ -20,7 +20,6 @@ use super::super::errors::CliError; | |||
| use super::common; | |||
Member
Author
There was a problem hiding this comment.
Note to myself: One regression test is needed to ensure that #4744 has been resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4744 by partially reverting eabe985.