-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(items): format comments after where using clause_shape budget #7156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ytmimi
merged 1 commit into
rust-lang:main
from
dbaileychess:fix-where-clause-comment-wrap
Oct 2, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // rustfmt-wrap_comments: true | ||
| // rustfmt-max_width: 100 | ||
| // rustfmt-comment_width: 100 | ||
|
|
||
| // Comments between `where` and the first predicate should be formatted using | ||
| // the full column budget rather than a budget derived from the header width. | ||
| impl<T> SomeTrait for LongTypeName<T> | ||
| where | ||
| // A long comment line between where and the first clause that fits within max width limit | ||
| // already. So no additional wrapping should occur. | ||
| T: SomeTrait, | ||
|
|
||
| // A long comment line between where and the first clause that fits within max width limit | ||
| // already. So no additional wrapping should occur. | ||
| T: OtherTrait, | ||
|
dbaileychess marked this conversation as resolved.
|
||
| { | ||
| } | ||
|
|
||
| // Comments between `where` and the first predicate should be formatted using | ||
| // the full column budget rather than a budget derived from the header width. | ||
| impl<T> SomeOtherTrait for LongTypeName<T> | ||
| where | ||
| // A long comment line between where and the first clause that doesn't fit within max width limit already. So additional wrapping should occur. | ||
| T: SomeTrait, | ||
|
|
||
| // A long comment line between where and the first clause that doesn't fit within max width limit already. So additional wrapping should occur. | ||
| T: OtherTrait, | ||
| { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // rustfmt-wrap_comments: true | ||
| // rustfmt-max_width: 100 | ||
| // rustfmt-comment_width: 100 | ||
|
|
||
| // Comments between `where` and the first predicate should be formatted using | ||
| // the full column budget rather than a budget derived from the header width. | ||
| impl<T> SomeTrait for LongTypeName<T> | ||
| where | ||
| // A long comment line between where and the first clause that fits within max width limit | ||
| // already. So no additional wrapping should occur. | ||
| T: SomeTrait, | ||
|
|
||
| // A long comment line between where and the first clause that fits within max width limit | ||
| // already. So no additional wrapping should occur. | ||
| T: OtherTrait, | ||
| { | ||
| } | ||
|
|
||
| // Comments between `where` and the first predicate should be formatted using | ||
| // the full column budget rather than a budget derived from the header width. | ||
| impl<T> SomeOtherTrait for LongTypeName<T> | ||
| where | ||
| // A long comment line between where and the first clause that doesn't fit within max width | ||
| // limit already. So additional wrapping should occur. | ||
| T: SomeTrait, | ||
|
|
||
| // A long comment line between where and the first clause that doesn't fit within max width | ||
| // limit already. So additional wrapping should occur. | ||
| T: OtherTrait, | ||
| { | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.