make -Ctarget-feature warnings more explicitly FCWs - #162237
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
target-feature
branch
from
September 3, 2026 13:43
8932114 to
c437406
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
target-feature
branch
from
September 3, 2026 14:40
c437406 to
f8df5fd
Compare
Collaborator
|
cc @rust-lang/miri |
JohnTitor
approved these changes
Sep 3, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
removed
the
S-waiting-on-bors
RalfJung
force-pushed
the
target-feature
branch
from
September 4, 2026 06:22
f8df5fd to
2fa835f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=JohnTitor |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 4, 2026
make -Ctarget-feature warnings more explicitly FCWs In rust-lang/compiler-team#994 we agreed that > We also change the warning emitted for unknown features in -Ctarget-feature to be explicitly a future-compat warning, and eventually we make unknown features in -Ctarget-feature a hard error. This PR implements that. I also created a new tracking issue specifically for this FCW as the old one has all sorts of discussion about us even figuring out the problem in the first place: rust-lang#162235.
This was referenced Sep 4, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
…uwer Rollup of 6 pull requests Successful merges: - #157808 (sanitizers: Implement support for the sanitize ignorelist) - #160660 (c-variadic: use `emit_ptr_va_arg` for `va_arg` on `sparc`) - #162237 (make -Ctarget-feature warnings more explicitly FCWs) - #160111 (Generalize Decodable impl for arrays to all types) - #162174 (Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`) - #162226 (Clean up the AST visitor)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
…uwer Rollup of 7 pull requests Successful merges: - #157808 (sanitizers: Implement support for the sanitize ignorelist) - #160660 (c-variadic: use `emit_ptr_va_arg` for `va_arg` on `sparc`) - #162237 (make -Ctarget-feature warnings more explicitly FCWs) - #160111 (Generalize Decodable impl for arrays to all types) - #162174 (Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`) - #162226 (Clean up the AST visitor) - #162281 (rustc-dev-guide subtree update)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
Rollup merge of #162237 - RalfJung:target-feature, r=JohnTitor make -Ctarget-feature warnings more explicitly FCWs In rust-lang/compiler-team#994 we agreed that > We also change the warning emitted for unknown features in -Ctarget-feature to be explicitly a future-compat warning, and eventually we make unknown features in -Ctarget-feature a hard error. This PR implements that. I also created a new tracking issue specifically for this FCW as the old one has all sorts of discussion about us even figuring out the problem in the first place: #162235.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust-lang/compiler-team#994 we agreed that
This PR implements that.
I also created a new tracking issue specifically for this FCW as the old one has all sorts of discussion about us even figuring out the problem in the first place: #162235.