Skip to content

Implement test- naming convention for CI jobs - #162092

Open
Kobzol wants to merge 7 commits into
rust-lang:mainfrom
Kobzol:ci-job-refactor
Open

Implement test- naming convention for CI jobs#162092
Kobzol wants to merge 7 commits into
rust-lang:mainfrom
Kobzol:ci-job-refactor

Conversation

@Kobzol

@Kobzol Kobzol commented Aug 31, 2026

Copy link
Copy Markdown
Member

This PR implements a naming convention for all jobs. Either they have to start with dist- (jobs that build artifacts) or test- (jobs that test stuff). It also performs some other minor cleanups and sorts the jobs, to make it easier to search through them in the GitHub UI.

r? jieyouxu

@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

rustc-dev-guide is developed in its own repository. If possible, consider making this change to rust-lang/rustc-dev-guide instead.

cc @BoxyUwU, @tshepang

@rustbot rustbot added A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Sort CI jobs
6cc3eda 
To make it easier to search through them in the GitHub UI.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu reviewed Sep 1, 2026
View reviewed changes
Comment thread src/ci/docker/host-x86_64/test-pr-check-1/Dockerfile
jieyouxu
jieyouxu approved these changes Sep 1, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once PR CI is green

View changes since this review

@Kobzol

Kobzol commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu rollup=never note="Renames many CI jobs"

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d1b8536 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
@bors
Auto merge of #162092 - Kobzol:ci-job-refactor, r=jieyouxu
0516e91 
Implement test- naming convention for CI jobs

This PR implements a naming convention for all jobs. Either they have to start with `dist-` (jobs that build artifacts) or `test-` (jobs that test stuff). It also performs some other minor cleanups and sorts the jobs, to make it easier to search through them in the GitHub UI.

r? jieyouxu
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2026
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0516e91 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2026
@Kobzol

Kobzol commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Oops, forgot to bless citool tests.

@bors r=jieyouxu

@rust-bors

rust-bors Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d9a564b has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2026
@JonathanBrouwer

JonathanBrouwer commented Sep 4, 2026

Copy link
Copy Markdown
Member

@bors p=6 scheduling

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
@bors
Auto merge of #162092 - Kobzol:ci-job-refactor, r=jieyouxu
28293c4 
Implement test- naming convention for CI jobs

This PR implements a naming convention for all jobs. Either they have to start with `dist-` (jobs that build artifacts) or `test-` (jobs that test stuff). It also performs some other minor cleanups and sorts the jobs, to make it easier to search through them in the GitHub UI.

r? jieyouxu
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2026
@rust-bors

rust-bors Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 28293c4 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Zalathar
Zalathar reviewed Sep 4, 2026
View reviewed changes
Comment thread src/ci/github-actions/jobs.yml
<<: *job-linux-4c

- name: test-various
- name: test-test-various

@Zalathar Zalathar Sep 4, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job already starts with test-, so it seems weird to change it to test-test-.

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zalathar Zalathar Zalathar left review comments
@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol @rustbot @rust-log-analyzer @JonathanBrouwer @Zalathar @jieyouxu