-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
add regression tests for the fn sig ice #160746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+130
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // issue-link: https://github.com/rust-lang/rust/issues/160591 | ||
| // A closure call with a struct literal missing a field shouldn't ICE when checking the fn sig. | ||
|
|
||
| trait Context {} | ||
| struct Wrapper<C: Context + 'static> { | ||
| container: &'static C, | ||
| } | ||
|
|
||
| fn main() { | ||
| let c = |_: Wrapper<()>| {}; //~ ERROR the trait bound `(): Context` is not satisfied | ||
| c(Wrapper { /* missing */ }); | ||
| //~^ ERROR the trait bound `(): Context` is not satisfied | ||
| //~^^ ERROR missing field `container` in initializer of `Wrapper<_>` | ||
| //~^^^ ERROR the trait bound `(): Context` is not satisfied | ||
| //~^^^^ ERROR the trait bound `(): Context` is not satisfied | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| error[E0277]: the trait bound `(): Context` is not satisfied | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:10:17 | ||
| | | ||
| LL | let c = |_: Wrapper<()>| {}; | ||
| | ^^^^^^^^^^^ the trait `Context` is not implemented for `()` | ||
| | | ||
| help: this trait has no implementations, consider adding one | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:4:1 | ||
| | | ||
| LL | trait Context {} | ||
| | ^^^^^^^^^^^^^ | ||
| note: required by a bound in `Wrapper` | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:5:19 | ||
| | | ||
| LL | struct Wrapper<C: Context + 'static> { | ||
| | ^^^^^^^ required by this bound in `Wrapper` | ||
|
|
||
| error[E0277]: the trait bound `(): Context` is not satisfied | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:11:7 | ||
| | | ||
| LL | c(Wrapper { /* missing */ }); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Context` is not implemented for `()` | ||
| | | ||
| help: this trait has no implementations, consider adding one | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:4:1 | ||
| | | ||
| LL | trait Context {} | ||
| | ^^^^^^^^^^^^^ | ||
| note: required by a bound in `Wrapper` | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:5:19 | ||
| | | ||
| LL | struct Wrapper<C: Context + 'static> { | ||
| | ^^^^^^^ required by this bound in `Wrapper` | ||
|
|
||
| error[E0063]: missing field `container` in initializer of `Wrapper<_>` | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:11:7 | ||
| | | ||
| LL | c(Wrapper { /* missing */ }); | ||
| | ^^^^^^^ missing `container` | ||
|
|
||
| error[E0277]: the trait bound `(): Context` is not satisfied | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:11:7 | ||
| | | ||
| LL | c(Wrapper { /* missing */ }); | ||
| | ^^^^^^^ the trait `Context` is not implemented for `()` | ||
| | | ||
| help: this trait has no implementations, consider adding one | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:4:1 | ||
| | | ||
| LL | trait Context {} | ||
| | ^^^^^^^^^^^^^ | ||
| note: required by a bound in `Wrapper` | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:5:19 | ||
| | | ||
| LL | struct Wrapper<C: Context + 'static> { | ||
| | ^^^^^^^ required by this bound in `Wrapper` | ||
|
|
||
| error[E0277]: the trait bound `(): Context` is not satisfied | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:11:5 | ||
| | | ||
| LL | c(Wrapper { /* missing */ }); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Context` is not implemented for `()` | ||
| | | ||
| help: this trait has no implementations, consider adding one | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:4:1 | ||
| | | ||
| LL | trait Context {} | ||
| | ^^^^^^^^^^^^^ | ||
| note: required by a bound in `Wrapper` | ||
| --> $DIR/ice-missing-field-fn-sig-closure.rs:5:19 | ||
| | | ||
| LL | struct Wrapper<C: Context + 'static> { | ||
| | ^^^^^^^ required by this bound in `Wrapper` | ||
|
|
||
| error: aborting due to 5 previous errors | ||
|
|
||
| Some errors have detailed explanations: E0063, E0277. | ||
| For more information about an error, try `rustc --explain E0063`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // issue-link: https://github.com/rust-lang/rust/issues/160591 | ||
| // A method call whose where-clause fails shouldn't ICE when checking the fn sig. | ||
|
|
||
| trait Context {} | ||
| struct Foo; | ||
| impl Foo { | ||
| fn take<T: Context>(&self, _: T) {} | ||
| } | ||
|
|
||
| fn main() { | ||
| let f = Foo; | ||
| f.take(()); | ||
| //~^ ERROR the trait bound `(): Context` is not satisfied | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| error[E0277]: the trait bound `(): Context` is not satisfied | ||
| --> $DIR/ice-missing-field-fn-sig-method.rs:12:12 | ||
| | | ||
| LL | f.take(()); | ||
| | ---- ^^ the trait `Context` is not implemented for `()` | ||
| | | | ||
| | required by a bound introduced by this call | ||
| | | ||
| help: this trait has no implementations, consider adding one | ||
| --> $DIR/ice-missing-field-fn-sig-method.rs:4:1 | ||
| | | ||
| LL | trait Context {} | ||
| | ^^^^^^^^^^^^^ | ||
| note: required by a bound in `Foo::take` | ||
| --> $DIR/ice-missing-field-fn-sig-method.rs:7:16 | ||
| | | ||
| LL | fn take<T: Context>(&self, _: T) {} | ||
| | ^^^^^^^ required by this bound in `Foo::take` | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
||
| For more information about this error, try `rustc --explain E0277`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add a links to issue in both tests
View changes since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done