Remove llvm_enzyme feature outside of bootstrap - #158460
Merged
Merged
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jul 7, 2026
…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 7, 2026
…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 7, 2026
…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 7, 2026
…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 7, 2026
…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460
rust-timer
added a commit
that referenced
this pull request
Jul 8, 2026
Rollup merge of #158333 - ZuseZ4:typetrees-for-enzyme3, r=oli-obk Fix typetree generation for differentiated functions Further improvements after #158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into #158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, #158460
ZuseZ4
force-pushed
the
simplify-enzyme-feature
branch
from
July 8, 2026 08:32
92263e0 to
8367b4e
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
simplify-enzyme-feature
branch
from
July 8, 2026 08:41
8367b4e to
e783526
Compare
rustbot
added
the
T-bootstrap
ZuseZ4
marked this pull request as ready for review
July 8, 2026 09:00
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Jul 14, 2026
bjorn3
reviewed
Jul 14, 2026
bjorn3
added
S-waiting-on-author
ZuseZ4
force-pushed
the
simplify-enzyme-feature
branch
from
July 28, 2026 20:12
e783526 to
ba87784
Compare
Member
Author
|
@bors try jobs=optional-x86_64-gnu-autodiff |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 28, 2026
Remove llvm_enzyme feature outside of bootstrap try-job: optional-x86_64-gnu-autodiff
This comment has been minimized.
This comment has been minimized.
Contributor
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 29, 2026
…bjorn3 Remove llvm_enzyme feature outside of bootstrap r? bjorn3 I think you were the one who did the last refactoring on how we pass this feature. We originally introduced and used this compile-time cfg since we were suspecting that some of the work we did for autodiff was causing a compile time regression even when no autodiff was used. It turned out later that we just did extra work due to a bug, which was fixed. Thanks to the dlopen work our checks are now much simpler. We only do autodiff work if the -Zautodiff=Enable flag was set. If the flag is set we also just check if libEnzyme is in the sysroot, and if we can not find it, we error out. I noticed it while fixing some related checks in rust-lang#158333
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
Rollup of 6 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160085 (Remove various superfluous lint attributes) - #160123 (add additional license option for third-party dependencies)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 29, 2026
…bjorn3 Remove llvm_enzyme feature outside of bootstrap r? bjorn3 I think you were the one who did the last refactoring on how we pass this feature. We originally introduced and used this compile-time cfg since we were suspecting that some of the work we did for autodiff was causing a compile time regression even when no autodiff was used. It turned out later that we just did extra work due to a bug, which was fixed. Thanks to the dlopen work our checks are now much simpler. We only do autodiff work if the -Zautodiff=Enable flag was set. If the flag is set we also just check if libEnzyme is in the sysroot, and if we can not find it, we error out. I noticed it while fixing some related checks in rust-lang#158333
This was referenced Jul 29, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
…uwer Rollup of 11 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159509 (Generate `valid_range`s for enums sign-agnostically) - #159632 (CFI: Add support for the adt_const_params feature) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #157058 (Rustdoc label badge for notable traits) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159850 (Add regression test for closure in array-length const generic) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160110 (convert rustc_hir::Target inherent methods to From impls) - #160123 (add additional license option for third-party dependencies) - #160131 (bootstrap: remove temporary bors email lookup)
Contributor
|
⌛ Testing commit ba87784 with merge 1cbbcd7... Workflow: https://github.com/rust-lang/rust/actions/runs/30457715708 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
Remove llvm_enzyme feature outside of bootstrap r? bjorn3 I think you were the one who did the last refactoring on how we pass this feature. We originally introduced and used this compile-time cfg since we were suspecting that some of the work we did for autodiff was causing a compile time regression even when no autodiff was used. It turned out later that we just did extra work due to a bug, which was fixed. Thanks to the dlopen work our checks are now much simpler. We only do autodiff work if the -Zautodiff=Enable flag was set. If the flag is set we also just check if libEnzyme is in the sysroot, and if we can not find it, we error out. I noticed it while fixing some related checks in #158333
Contributor
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #160146. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
…uwer Rollup of 11 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159509 (Generate `valid_range`s for enums sign-agnostically) - #159632 (CFI: Add support for the adt_const_params feature) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #157058 (Rustdoc label badge for notable traits) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159850 (Add regression test for closure in array-length const generic) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160110 (convert rustc_hir::Target inherent methods to From impls) - #160123 (add additional license option for third-party dependencies) - #160131 (bootstrap: remove temporary bors email lookup)
rust-timer
added a commit
that referenced
this pull request
Jul 29, 2026
Rollup merge of #158460 - ZuseZ4:simplify-enzyme-feature, r=bjorn3 Remove llvm_enzyme feature outside of bootstrap r? bjorn3 I think you were the one who did the last refactoring on how we pass this feature. We originally introduced and used this compile-time cfg since we were suspecting that some of the work we did for autodiff was causing a compile time regression even when no autodiff was used. It turned out later that we just did extra work due to a bug, which was fixed. Thanks to the dlopen work our checks are now much simpler. We only do autodiff work if the -Zautodiff=Enable flag was set. If the flag is set we also just check if libEnzyme is in the sysroot, and if we can not find it, we error out. I noticed it while fixing some related checks in #158333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? bjorn3
I think you were the one who did the last refactoring on how we pass this feature.
We originally introduced and used this compile-time cfg since we were suspecting that some of the work we did for autodiff was causing a compile time regression even when no autodiff was used. It turned out later that we just did extra work due to a bug, which was fixed.
Thanks to the dlopen work our checks are now much simpler. We only do autodiff work if the -Zautodiff=Enable flag was set. If the flag is set we also just check if libEnzyme is in the sysroot, and if we can not find it, we error out.
I noticed it while fixing some related checks in #158333