Fix ambiguity of RESERVED_RAW_IDENTIFIER #2122
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies that the literals expressed in the RESERVED_RAW_IDENTIFIER rule cannot be followed by a XID_Continue character. Originally in my mind these literals were to be interpreted as tokens (and thus assume some kind of break follows them). However, since this is part of the lexer itself, this doesn't really work for it to be defined this way. This helps ensure that strings like `r#_f` or `r#selfie` are not interpreted as reserved raw identifiers.
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies that the literals expressed in the
RESERVED_RAW_IDENTIFIER rule cannot be followed by a XID_Continue character. Originally in my mind these literals were to be interpreted as tokens (and thus assume some kind of break follows them). However, since this is part of the lexer itself, this doesn't really work for it to be defined this way.
This helps ensure that strings like
r#_forr#selfieare not interpreted as reserved raw identifiers.