Use impl restrictions over hand-sealed traits#529
Open
jhpratt wants to merge 1 commit into
Open
Conversation
Member
Author
|
Note: |
Member
|
Because std::simd is just a module of the core library, we can't actually use this feature until core does. |
Member
Author
|
Gotcha. rust-lang/rust#157170 will need to be merged first then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of rust-lang/rust#105077, I'm beginning to use
#![feature(impl_restriction)]within the standard library. As portable SIMD is relied upon by the standard library (as a submodule), I thought I would start here.I have tested the feature myself in a number of situations and have found it works as expected. Feel free to ask any questions you may have.