musl: Rename musl_v1_2_3 to musl_v1_2 - #5376
Merged
Merged
Conversation
rustbot
added
A-CI
Contributor
Author
|
@xbjfk mind taking a look at this? |
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 6, 2026 08:56
896f2e8 to
0f4a181
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 6, 2026 09:55
0f4a181 to
12306de
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 9, 2026 21:19
12306de to
c1ac9d6
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 10, 2026 00:27
c1ac9d6 to
8219e6e
Compare
tgross35
changed the title
musl_v1_2_3 to musl_v1_2musl_v1_2_3 to musl_v1_2
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 11, 2026 09:34
8219e6e to
386ace2
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 11, 2026 09:45
386ace2 to
78c0681
Compare
1.2.0 was the release that introduced 64-bit `time_t` everywhere [1], which is the main thing we are interested in with this config. There is nothing special about 1.2.3, and most gated API will work down to 1.2.0. This has been a source of mild confusion. To make things more clear, drop the `_3`. We continue to support `libc_unstable_musl_v1_2_3` for now but emit a warning if set. Closes: rust-lang#5200 [1]: https://musl.libc.org/releases.html
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 11, 2026 09:49
78c0681 to
85daadc
Compare
tgross35
force-pushed
the
musl-version-simplify
branch
from
August 11, 2026 09:58
85daadc to
df82dd7
Compare
tgross35
added
the
stable-nominated
This was referenced Aug 11, 2026
Contributor
|
Hey, sorry was not able to take a look earlier but LGTM |
Contributor
Author
|
Thanks for taking a look when you could :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.2.0 was the release that introduced 64-bit
time_teverywhere 1,which is the main thing we are interested in with this config. There is
nothing special about 1.2.3, and most gated API will work down to 1.2.0.
This has been a source of mild confusion.
To make things more clear, drop the
_3. We continue to supportlibc_unstable_musl_v1_2_3for now but emit a warning if set.Closes: #5200