Skip to content

svelte: Improve $props() usage #12549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Turbo87 merged 2 commits into from
Dec 19, 2025
+8 −8
Merged

svelte: Improve $props() usage #12549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab2f41a
svelte: Use `HTMLAttributes` type instead of generic record object
Turbo87 Dec 18, 2025
bdba5d0
svelte: Merge `class` attributes instead of overriding them
Turbo87 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions svelte/src/lib/components/PageHeader.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<script lang="ts">
import type { Snippet } from 'svelte';
import type { HTMLAttributes } from 'svelte/elements';

// TODO: import LoadingSpinner from './LoadingSpinner.svelte';

interface Props {
interface Props extends HTMLAttributes<HTMLDivElement> {
title?: string;
suffix?: string;
showSpinner?: boolean;
children?: Snippet;
[key: string]: unknown;
}

let { title, suffix, showSpinner = false, children, ...others }: Props = $props();
let { title, suffix, showSpinner = false, children, class: className, ...others }: Props = $props();
</script>

<div data-test-page-header class="header" {...others}>
<div data-test-page-header class={['header', className]} {...others}>
{#if children}
{@render children()}
{:else}
Expand Down
8 changes: 4 additions & 4 deletions svelte/src/lib/components/TextContent.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<script lang="ts">
import type { Snippet } from 'svelte';
import type { HTMLAttributes } from 'svelte/elements';

interface Props {
interface Props extends HTMLAttributes<HTMLDivElement> {
boxed?: boolean;
children: Snippet;
[key: string]: unknown;
}

let { boxed = false, children, ...others }: Props = $props();
let { boxed = false, children, class: className, ...others }: Props = $props();
</script>

<div class="wrapper" class:boxed {...others}>
<div class={['wrapper', className, { boxed }]} {...others}>
{@render children()}
</div>

Expand Down