ci: Disable install-action fallback for nextest - #1253
Conversation
This should make it fall back to a system-wide cargo-nextest install or running the tests without nextest, which is probably still faster than building nextest from source.
0583bcf to
657b55a
Compare
| - uses: taiki-e/install-action@7a79fe8c3a13344501c80d99cae481c1c9085912 # v2.81.10 | ||
| continue-on-error: true | ||
| with: | ||
| tool: nextest@0.9.131 | ||
| # On platforms without prebuilts, nextest can be installed system-wide | ||
| # or omitted. Building it probably takes longer than running tests | ||
| # without it | ||
| fallback: none |
There was a problem hiding this comment.
I was thinking that it would be good to keep the binstall fallback (seems to be default https://github.com/taiki-e/install-action#supported-tools) because nextest could add other arches. Looking at it, seems like you can tell binstall to not do the install by setting an env, would you be able to see if that works?
--disable-strategies <DISABLE_STRATEGIES>
Disable the strategies specified. If a strategy is specified in `--strategies` and `--disable-strategies`, then it will be removed [env: BINSTALL_DISABLE_STRATEGIES=] [possible values: crate-meta-data, quick-install, compile]
There was a problem hiding this comment.
Though then again, I hope it doesn't build+install binstall if that's not available.
@taiki-e do you have any advice for what we might want here? Basically to install directly if supported, install via binstall if we can download it, but never spend time building either binstall or nextest.
I think showing up as an error is fine to make it easy to see if some other arch stops getting the install for some reason. Would be nice if GH could show warnings instead of red everywhere...
There was a problem hiding this comment.
Um, nextest/binstall/quickinstall don't provide prebuilt ppc64/ppc64le/s390x binaries.
I think the easiest way is to add if: to exclude them as before #1019.
Or add an option something like fallback: skip to install-action.
Since nextest uses upload-rust-binary-action with cross/cargo-zigbuild, I think providing prebuilt binaries for s390x gnu and powerpc64le gnu/musl in nextest side should be easy, but I'm not sure about powerpc64 musl.
https://github.com/nextest-rs/nextest/blob/28725d46d6cfe57d505a4e500e3c99c81263848c/.github/workflows/release.yml#L132
There was a problem hiding this comment.
They don't have installers now, but one reason to avoid an if is so we just get it automatically if they start publishing a version. It would be nice if they added them though I don't know that it's worth it, given we're probably pretty much the only consumers.
In that case, I think the current fallback: none is fine?
|
☔ The latest upstream changes (possibly #1263) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@Gelbpunkt could you rebase this? I don't think we can do any better, so I'm happy to merge. |
4 participants
This should make it fall back to a system-wide cargo-nextest install or running the tests without nextest, which is probably still faster than building nextest from source.