cc-test: add loongarch64 assembly shim - #1855
Merged
Merged
Conversation
NobodyXu
reviewed
Aug 13, 2026
Contributor
Author
|
I dropped the So this PR is just the shim for now. It is verified on a real LoongArch64 machine: the assembly compiles and |
Contributor
|
Thanks, merged |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dev-tools/cc-test'sbuild.rscompilessrc/<arch>.Sbased on the target architecture.aarch64.S,armv7.S,i686.S,riscv64gc.S, andx86_64.Sare all present, but there is noloongarch64.S. Onloongarch64-unknown-linux-gnu(stable Rust target since 1.75) this fails with:The
cccrate itself already declares support for LoongArch64 (loongarch64-unknown-linux-gnu => loongarch64-linux-gnuinsrc/lib.rs), so this is purely a missing dev-tool shim.Fix
Add
dev-tools/cc-test/src/loongarch64.S, modeled onriscv64gc.S, exporting bothasmand_asmsymbols. Verified on real LoongArch64 hardware:cargo buildsucceeds andcargo testpasses 9/9 — theasm_heretest asserts the shim returns 7.