cc: fix compilation on Rust 1.64 - #1823
Merged
Merged
Conversation
NobodyXu
reviewed
Jul 31, 2026
NobodyXu
requested changes
Jul 31, 2026
xtqqczze
marked this pull request as ready for review
July 31, 2026 17:07
xtqqczze
force-pushed
the
deprecated
branch
2 times, most recently
from
July 31, 2026 19:32
c17dfca to
5e25e2b
Compare
xtqqczze
changed the title
```log warning: use of deprecated method `cc::Build::static_flag`: cc only creates static libraries, setting this does nothing --> tests/cflags.rs:38:10 | 38 | .static_flag(true) | ^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default ```
```log error[E0658]: use of unstable library feature 'is_some_with' --> src/bin/cc-shim.rs:87:18 | 87 | .is_some_and(|a| a == "cl"); | ^^^^^^^^^^^ | = note: see issue #93050 <rust-lang/rust#93050> for more information ```
```log
warning: unnecessary `unsafe` block
--> tests/support/global_env.rs:70:9
|
70 | unsafe { env::set_var(&key, value) };
| ^^^^^^ unnecessary `unsafe` block
|
= note: `#[warn(unused_unsafe)]` on by default
```
NobodyXu
approved these changes
Aug 1, 2026
NobodyXu
left a comment
NobodyXu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, given the size of the file allow deprecated probably fine
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.