-
Notifications
You must be signed in to change notification settings - Fork 322
feat(inside-rust): announce rustup 1.29.0 beta CFT #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e43ce5e to
01b8d6a
Compare
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I think that sharing rustup releases on the Rust blog makes a lot of sense. Added a comment with a link to the GSoC event, otherwise LGTM, and happy to merge this for you. Just let me know if you want me to merge now or if you want to make any edits.
|
@Kobzol Let's just wait for a few moments in case our team has some more edit suggestions :) |
djc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nit: might be nice to break up the long lines.
01b8d6a to
bb51d3c
Compare
|
I think I have addressed all the concerns above, but I don't think I'll be the one to press the merge button despite having the permission :) |
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
|
Great post. I love it! One thing may be worth mentioning: I found that @rami3l didn't acknowledge themselves in the post. Rami did a really great job at mentoring the GSoC project and leading the team! |
As a part of rust-lang/rustup#4652, this is my first attempt doing such an announcement on another platform other than the "internals" forum.
If this turns out to gain more attention, I'd be glad to change the release process so that the forum post can point directly to this post instead.
Many thanks in advance for your help with our little experiment! 🙏
cc @rust-lang/rustup @FranciscoTGouveia
Rendered