Repository navigation
server: /opensearchdescription が 500 になるのを直す - #339
Merged
Merged
Conversation
OpenSearchDescriptionScreen#body が run_template の既定(layout あり)で HTML の layout を通していたため、layout が呼ぶ charset() がこのクラスに無く NoMethodError で 500 になっていた(alias charset encoding は他のクラスだけ)。 XML を HTML の layout で包むのもおかしいので、layout を通さず テンプレートだけを描画する。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
znz
commented
Sep 25, 2026
| require 'bitclust' | ||
| require 'bitclust/screen' | ||
|
|
||
| # bitclust server の /opensearchdescription(rurema/bitclust の出力監査 2026-09): |
Member
Author
There was a problem hiding this comment.
経緯はコミットログや PR などに書いてコード中には残さないでください。
経緯はコミットログと PR に残す。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 25, 2026
Merged
This was referenced Sep 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #335(不具合 4)
概要
bitclust serverの/opensearchdescriptionが 500 になっていました。OpenSearchDescriptionScreen#bodyがrun_templateの既定(layout あり)で HTML の layout を通しており、layout が呼ぶcharset()がこのクラスに無い(alias charset encodingは他のクラスだけ)ためNoMethodErrorでした。そもそも XML を HTML の layout で包むのもおかしいので、layout を通さずテンプレートだけを描画します。検証
test/test_opensearchdescription_screen.rb(2 件: 本文が<?xmlで始まり<htmlを含まないこと・Content-Type)・全テスト green/view/opensearchdescriptionが 200・application/opensearchdescription+xml; charset=utf-8🤖 Generated with Claude Code