fix: embed CA certificates for environments without system certs#238
Merged
TimPietruskyRunPod merged 1 commit intomainfrom Mar 3, 2026
Merged
fix: embed CA certificates for environments without system certs#238TimPietruskyRunPod merged 1 commit intomainfrom
TimPietruskyRunPod merged 1 commit intomainfrom
Conversation
justinwlin
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/crypto/x509roots/fallbackto embed Mozilla's CA certificate bundle in the binaryca-certificatesinstalled (e.g. minimal Docker images likeubuntu:22.04)The problem
Running
runpodctlfrom inside a container based on a minimal image (withoutca-certificates) fails:Verified
Tested on a live Runpod pod:
ca-certificatesfrom a running pod to simulate bareubuntu:22.04x509: certificate signed by unknown authority401(expected with fake API key)Fixes #149