feat: add native plugin and hook sync#138
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces native integrations for Claude and Codex through new plugin and hook management systems, including CLI commands for listing, importing, and syncing these resources. The changes update core commands like status, diff, and sync --all to support these integrations and provide comprehensive documentation and testing utilities. Feedback focuses on improving robustness and performance, specifically addressing silent error handling in configuration discovery, inefficient JSON and file I/O operations, and fragile string parsing or TOML editing logic that could lead to panics or incorrect behavior.
|
Thanks for the PR! I'll take a closer look and try it out. |
|
@runkids I'm interested in seeing if you can get plugins and hooks working on skillshare. |
|
is there something i can help with to push this? @runkids |
Summary
pluginsandhookssource/sync flows for Claude and Codexstatus,diff,doctor, andsync --allBehavior Notes
hooks sync --target allkeeps successful rows plus warning/no-op rows such asno codex hooks defineduse full refVerification
make fmtmake fmt-checkmake lintmake buildmake checkmake test-redteam./scripts/test_docker.sh./scripts/test_docker_online.shpassed locally; token/private-repo cases were skipped withoutGITHUB_TOKENcd website && npm run buildplugins import/list/synchooks import/list/syncstatus --jsondiff --jsondoctor --jsonsync --all --jsonclaudebinaryAdditional Note
make checkRefs #133