avm2: Include attribute and element name in XML parser error 1104 - #24352
Open
evilpie wants to merge 2 commits into
Open
avm2: Include attribute and element name in XML parser error 1104#24352evilpie wants to merge 2 commits into
evilpie wants to merge 2 commits into
Conversation
evilpie
force-pushed
the
xml-duplicate-attr-error
branch
2 times, most recently
from
August 8, 2026 11:23
5bafc6e to
ee4666b
Compare
evilpie
marked this pull request as ready for review
August 8, 2026 11:23
evilpie
added
A-avm2
Dinnerbone
approved these changes
Aug 19, 2026
| return Err(make_error_1088(activation)); | ||
| } | ||
| Err(XmlError::InvalidAttr(XmlAttrError::Duplicated(_, _))) => { | ||
| return Err(make_xml_error(activation, XmlErrorCode::DuplicateAttribute)); |
Member
There was a problem hiding this comment.
Is this case now unreachable? Why was it removed?
Collaborator
Author
There was a problem hiding this comment.
This must have always been unreachable.
Member
There was a problem hiding this comment.
Can you explicitly mark it unreachable!() and explain why then, so someone doesn't try to handle it in the future?
evilpie
force-pushed
the
xml-duplicate-attr-error
branch
from
August 20, 2026 07:05
ee4666b to
343e4d6
Compare
evilpie
enabled auto-merge (rebase)
August 20, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The XML parser error #1104 for duplicate attributes should include the name of the attribute and element name.
Testing
Checklist