Skip to content

linter compliance for volunteer_datatable.rb #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FireLemons merged 1 commit into from
Nov 11, 2026
Merged

linter compliance for volunteer_datatable.rb #7369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .standard_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ ignore:
- app/controllers/users/sessions_controller.rb:
- Layout/EmptyLinesAfterModuleInclusion
- Rails/LexicallyScopedActionFilter
- app/datatables/volunteer_datatable.rb:
- Rails/CompactBlank
- Style/EmptyStringInsideInterpolation
- app/decorators/casa_case_decorator.rb:
- Layout/EmptyLineAfterGuardClause
- Rails/Date
Expand Down
4 changes: 2 additions & 2 deletions app/datatables/volunteer_datatable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def supervisor_filter
"supervisors.id IS NULL"
else
null_filter = "supervisors.id IS NULL OR" if filter.any?(&:blank?)
["#{null_filter} COALESCE(supervisors.id) IN (?)", filter.select(&:present?)]
["#{null_filter} COALESCE(supervisors.id) IN (?)", filter.compact_blank]
end
end

Expand All @@ -247,7 +247,7 @@ def transition_aged_youth_filter
filter = additional_filters[:transition_aged_youth]

bool_filter filter do
"transition_aged_youth_cases.volunteer_id IS #{(filter[0] == "true") ? "NOT" : nil} NULL"
"transition_aged_youth_cases.volunteer_id IS #{"NOT" if filter[0] == "true"} NULL"
end
}.call
end
Expand Down
Loading