Proposal to add common prefix completion for autocompletion mode #880
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the first tab press on autocompletion mode performs common prefix
completion, like the tab press on non-autocompletion mode.
For instance, when having candidates %w[ab1 ab2 ab3 c]:
1. User inputs "a"
2. First Tab: Complete to common prefix (e.g., "a" → "ab" with menu displayed)
3. Second Tab: Select first candidate (e.g., "ab" → "ab1")
4. Subsequent Tabs: Cycle through candidates + common prefix ("ab")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me propose to add the "common prefix completion" for the first tab hit on autocompletion mode.
The behavior is similar to the tab hit on non-autocompletion mode, and then it cycles through the candidates just as the current autocompletion mode behaves. I think this is how most of the modern shells e.g., bash, zsh, etc. behave by default.
As a realistic example, when having candidates
now we can get to "instance_variable_get" with the following three steps:
You can confirm this exact behavior with this one liner on this branch:
ruby -Ilib -rreline -e "Reline.autocompletion = true; Reline.completion_proc = proc { |s| %w[instance_of? instance_variable_defined? instance_variable_get instance_variable_set instance_variables].select { |i| i.start_with?(s) } }; puts Reline.readline('> ')"