Calculate phase agreement over symmetry-allowed origin shifts - #355
Draft
tjlane wants to merge 1 commit into
Draft
Calculate phase agreement over symmetry-allowed origin shifts#355tjlane wants to merge 1 commit into
tjlane wants to merge 1 commit into
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
! This PR was vibe-coded.
Stack
Part 5 of 11 for #31. Depends on #354. Merge bottom-up.
Next branch: codex/phase-alignment-06-bounded-fft.
What this implements
Adds the exact numerical foundation for a symmetry-constrained origin search: an integer basis for the continuous polar lattice, per-coset Fourier terms, Nyquist-complete intrinsic-dimensional grids, a materialized inverse FFT, and a memory safety estimate.
The implementation supports zero through three floating dimensions and oblique axes such as R 3:R.
Tests
Tests compare FFT grid values directly against the circular-correlation objective in one, two, and three dimensions; cover exact integer bases, zero-weight frequencies, oblique rhombohedral axes, and the materialized-memory guard.
Reviewer focus
Related: #31 and #174.