Skip to content

Calculate phase agreement over symmetry-allowed origin shifts - #355

Draft
tjlane wants to merge 1 commit into
codex/phase-alignment-04-reindex-hardeningfrom
codex/phase-alignment-05-origin-fft
Draft

Calculate phase agreement over symmetry-allowed origin shifts#355
tjlane wants to merge 1 commit into
codex/phase-alignment-04-reindex-hardeningfrom
codex/phase-alignment-05-origin-fft

Conversation

@tjlane

@tjlane tjlane commented Aug 22, 2026

Copy link
Copy Markdown
Member

! This PR was vibe-coded.

Stack

Part 5 of 11 for #31. Depends on #354. Merge bottom-up.

Next branch: codex/phase-alignment-06-bounded-fft.

What this implements

Adds the exact numerical foundation for a symmetry-constrained origin search: an integer basis for the continuous polar lattice, per-coset Fourier terms, Nyquist-complete intrinsic-dimensional grids, a materialized inverse FFT, and a memory safety estimate.

The implementation supports zero through three floating dimensions and oblique axes such as R 3:R.

Tests

Tests compare FFT grid values directly against the circular-correlation objective in one, two, and three dimensions; cover exact integer bases, zero-weight frequencies, oblique rhombohedral axes, and the materialized-memory guard.

Reviewer focus

  • The integer polar-basis construction and its behavior for R settings.
  • Fourier sign, frequency wrapping, inverse-FFT scaling, and grid-size choice.
  • The distinction between discrete origin cosets and continuous polar coordinates.

Related: #31 and #174.

@tjlane tjlane changed the title Add constrained origin Fourier grid Calculate phase agreement over symmetry-allowed origin shifts Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant