Check when alternative indexing or origin shifts are possible - #351
Draft
tjlane wants to merge 1 commit into
Draft
Check when alternative indexing or origin shifts are possible#351tjlane wants to merge 1 commit into
tjlane wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 86.86% 87.23% +0.36%
==========================================
Files 40 43 +3
Lines 2856 2962 +106
==========================================
+ Hits 2481 2584 +103
- Misses 375 378 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
! This PR was vibe-coded.
Stack
Part 1 of 11 for #31. Merge this stack from the bottom upward.
Next branch: codex/phase-alignment-02-reindex-core.
What this implements
Tests
The tests cover exact and pseudo-merohedral metric cases, invalid metadata and tolerances, representative discrete and polar origin cases, every reference space group, all Gemmi settings, and the import-order regression.
Reviewer focus
Related: #31 and #174. This prerequisite does not close the issue.