Replace slice-based aircraft tracking with map[string]bool#14
Draft
Replace slice-based aircraft tracking with map[string]bool#14
Conversation
Agent-Logs-Url: https://github.com/rorpage/gee-bee/sessions/df5ce99c-c237-4cbc-aa9f-7fe0f3752344 Co-authored-by: rorpage <[email protected]>
Copilot created this pull request from a session on behalf of
rorpage
April 14, 2026 10:13
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spotted-aircraft state was managed as a
[]Aircraftslice, requiring four helper functions (containsAircraft,newlySpotted,updateSpottedAircraft,validateAircraft) and awkward pointer-to-slice threading across the call stack to implement what is fundamentally a set membership check.Changes
geebee.go: Removed the four slice-management helpers.HandleAircraftnow accepts amap[string]bool(keyed by ICAO) and inlines the logic — O(1) lookup/insert for new sightings, a single range+delete pass to evict aircraft that left range.main.go: Replaced*[]geebee.Aircraftwithmap[string]bool{}— no pointer indirection needed since maps are reference types.Net: −48 lines, +21 lines, identical behaviour.