[test] Disable Firefox and Chrome webgui tests if webgui=OFF
#20804
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an inconcistency that we didn't catch in the CI, because no web browser is installed in the environment where we test the minimal build with implicit `webgui=OFF`.
The ROOT libraries are now always found thanks to the RPATH mechanism, so we don't need to set `LD_LIBRARY_PATH` for tests.
dpiparo
approved these changes
Jan 6, 2026
Test Results 22 files 22 suites 3d 22h 38m 15s ⏱️ For more details on these failures, see this check. Results for commit b301287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an inconsistency that we didn't catch in the CI, because no web browser is installed in the environment where we test the minimal build with implicit
webgui=OFF.Also, remove some unnecessary
LD_LIBRARY_PATHenvironment variables.