This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix: loose strategy when suffer trailing comma in json#4379
Draft
IWANABETHATGUY wants to merge 2 commits intorome:mainfrom
Draft
fix: loose strategy when suffer trailing comma in json#4379IWANABETHATGUY wants to merge 2 commits intorome:mainfrom
IWANABETHATGUY wants to merge 2 commits intorome:mainfrom
Conversation
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
Contributor
|
I am a bit hesitant about this "fix":
How did you want to introduce this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ "test", "something", "another", "something", }trailing comma syntax error is a common syntax error when copying and pasting something in the json file, we could lose this kind of syntax error, and give our formatter a chance to format the code, like pretty did.
tools/crates/rome_json_formatter/tests/specs/prettier/json/json/array.json.snap
Lines 23 to 39 in 9bc3f89
Test Plan
Changelog
Documentation