Plumb SST metadata information through rockdb::FileOptions - #371
Closed
anubhavbn wants to merge 1 commit into
Closed
Plumb SST metadata information through rockdb::FileOptions#371anubhavbn wants to merge 1 commit into
anubhavbn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
FileOptions, so custom file systems can make per-read routing decisions after opening an SST..sstto.ldbfallback opens, and direct table-properties reads.FileOptions.Test plan:
DBSSTTest.PassesSstMetadataToFileSystem, using a recording file system wrapper to verify normal.sstopens and.ldbfallback opens receive the same file size and tail size recorded in RocksDB metadata.DBSSTTest.SSTsWithLdbSuffixHandlingcontinues to cover successful reads through the legacy filename fallback.make -j2 db_basic_test.make -j2 db_sst_test../db_sst_test --gtest_filter=DBSSTTest.PassesSstMetadataToFileSystem:DBSSTTest.SSTsWithLdbSuffixHandling.