Skip to content

fix(dist): allow dirty CI to permit manual additions to release.yml - #16

Merged
robdefeo merged 1 commit into
mainfrom
fix/dist-allow-dirty-ci
Apr 23, 2026
Merged

fix(dist): allow dirty CI to permit manual additions to release.yml#16
robdefeo merged 1 commit into
mainfrom
fix/dist-allow-dirty-ci

Conversation

@robdefeo

Copy link
Copy Markdown
Owner

Summary

  • cargo-dist checks that release.yml matches what it would generate and fails the plan step if it doesn't
  • Our manual Homebrew publish step causes this check to fail
  • Adding allow-dirty = ["ci"] to dist-workspace.toml tells cargo-dist to skip the freshness check for the CI file

Test plan

  • Merge, delete and re-cut the release, verify the plan step passes

@greptile-apps

greptile-apps Bot commented Apr 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds a single line — allow-dirty = ["ci"] — to dist-workspace.toml to fix a cargo-dist CI check failure caused by the manual Homebrew publish step that was added to release.yml. By default, cargo-dist regenerates release.yml during the plan step and fails if the committed file differs from what it would generate; allow-dirty = ["ci"] opts out of that freshness check for the CI file, letting the manual additions coexist without breakage.

Changes:

  • dist-workspace.toml: Added allow-dirty = ["ci"] with an explanatory comment to suppress the cargo-dist CI file freshness check.

Confidence Score: 5/5

Safe to merge — minimal, well-scoped config change with no logic or security implications.

The change is a single, well-documented config line that uses a standard cargo-dist feature exactly as intended. It has no side effects beyond allowing the manual CI additions to coexist with cargo-dist's generated output.

No files require special attention.

Important Files Changed

Filename Overview
dist-workspace.toml Adds allow-dirty = ["ci"] to the [dist] section so cargo-dist skips the CI freshness check that would otherwise reject the manually-extended release.yml.

Reviews (1): Last reviewed commit: "fix(dist): allow dirty CI file to permit..." | Re-trigger Greptile

@robdefeo
robdefeo merged commit 1287453 into main Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant