Skip to content

Fix command_sender.h#304

Open
Whathelp233 wants to merge 1 commit intorm-controls:masterfrom
Whathelp233:RM2026
Open

Fix command_sender.h#304
Whathelp233 wants to merge 1 commit intorm-controls:masterfrom
Whathelp233:RM2026

Conversation

@Whathelp233
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 15, 2026 12:13
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2026

Deploy Preview for rm-control ready!

Name Link
🔨 Latest commit e80b6ac
🔍 Latest deploy log https://app.netlify.com/projects/rm-control/deploys/69df80ea0b9bdb0008483524
😎 Deploy Preview https://deploy-preview-304--rm-control.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates command_sender.h by removing a generic SFINAE-based helper for setting a trajectory frame id and replacing it with a direct assignment on the gimbal command sender, alongside a rename of the setter method.

Changes:

  • Removed detail::setTrajFrameIdIfSupported helper templates.
  • Renamed GimbalCommandSender’s trajectory frame-id setter and now assigns msg_.traj_frame_id directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
detail::setTrajFrameIdIfSupported(msg_, traj_frame_id, 0);
msg_.traj_frame_id = traj_frame_id;
}
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the public method from setTrajFrameId to setGimbalTrajFrameId in this installed header is an API-breaking change for any downstream code that includes command_sender.h. Consider keeping a backward-compatible setTrajFrameId(const std::string&) wrapper that forwards to setGimbalTrajFrameId (optionally marking it deprecated) so existing call sites keep compiling.

Suggested change
}
}
void setTrajFrameId(const std::string& traj_frame_id)
{
setGimbalTrajFrameId(traj_frame_id);
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants