Conversation
✅ Deploy Preview for rm-control ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates command_sender.h by removing a generic SFINAE-based helper for setting a trajectory frame id and replacing it with a direct assignment on the gimbal command sender, alongside a rename of the setter method.
Changes:
- Removed
detail::setTrajFrameIdIfSupportedhelper templates. - Renamed
GimbalCommandSender’s trajectory frame-id setter and now assignsmsg_.traj_frame_iddirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| detail::setTrajFrameIdIfSupported(msg_, traj_frame_id, 0); | ||
| msg_.traj_frame_id = traj_frame_id; | ||
| } |
There was a problem hiding this comment.
Renaming the public method from setTrajFrameId to setGimbalTrajFrameId in this installed header is an API-breaking change for any downstream code that includes command_sender.h. Consider keeping a backward-compatible setTrajFrameId(const std::string&) wrapper that forwards to setGimbalTrajFrameId (optionally marking it deprecated) so existing call sites keep compiling.
| } | |
| } | |
| void setTrajFrameId(const std::string& traj_frame_id) | |
| { | |
| setGimbalTrajFrameId(traj_frame_id); | |
| } |
No description provided.