-
Notifications
You must be signed in to change notification settings - Fork 150
feat: Comic Sans font for light mode (experimental) #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Use Comic Sans MS in light mode for UI experiments and testing - Dark mode maintains default system fonts - Improved CSS specificity with :not(.dark) selector - Clearly marked as experimental feature
|
🚅 Deployed to the rivet-pr-4070 environment in rivet-frontend
|
PR Review: Comic Sans Font for Light ModeOverviewThis PR adds Comic Sans MS as the font family for light mode only. While the implementation is technically correct, there are several concerns to consider. Code Quality ✅Pros:
Technical Implementation: The selector and syntax are correct. Issues & Concerns
|
Overview
This PR introduces Comic Sans MS font as an experimental feature for light mode only. This is intended for UI testing, demos, and experimental purposes.
Changes
Frontend (
frontend/src/index.css)::root:not(.dark)selector for better CSS specificityImplementation Details
CSS Specificity:
:not(.dark)pseudo-class for explicit light mode targetingcursive, sans-serifUse Cases
Notes
Testing