Skip to content

Conversation

@NathanFlurry
Copy link
Member

The skills workflow was copying generated skills to the root of rivet-dev/skills repo instead of the skills/ subdirectory.

Changes

  • Copy skills to skills-repo/skills/$skill_name instead of skills-repo/$skill_name
  • Ensure skills/ directory exists before copying
  • Remove the hardcoded rivetkit-typescript cleanup (not needed)

@railway-app
Copy link

railway-app bot commented Jan 29, 2026

🚅 Deployed to the rivet-pr-4065 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Jan 30, 2026 at 7:54 am
frontend-inspector ✅ Success (View Logs) Web Jan 30, 2026 at 7:51 am
website 😴 Sleeping (View Logs) Web Jan 30, 2026 at 7:24 am
mcp-hub ✅ Success (View Logs) Web Jan 29, 2026 at 1:38 pm

@claude
Copy link

claude bot commented Jan 29, 2026

PR Review: Fix CI skills directory structure

Summary

This PR correctly fixes the skills publishing workflow to copy generated skills to the skills/ subdirectory in the rivet-dev/skills repository instead of the repo root.

Code Quality ✅

The changes are clean and well-commented:

  • Added clear comment explaining the mkdir -p command
  • Fixed the hardcoded cleanup of rivetkit-typescript which was inconsistent with the dynamic approach
  • The loop now correctly handles all skills uniformly

Implementation Review ✅

Before: Skills were being copied to skills-repo/$skill_name (repo root)
After: Skills are copied to skills-repo/skills/$skill_name (correct subdirectory)

The fix properly:

  1. Creates the skills/ directory if it doesn't exist (mkdir -p)
  2. Removes the hardcoded special case for rivetkit-typescript
  3. Updates both the rm -rf and cp -r commands to use the correct path

Potential Issues

None identified. The changes are straightforward and correct.

Testing Verification

The PR description mentions testing instructions in the workflow file comments. You can verify the fix works by:

  1. Running: gh workflow run skills.yml --repo rivet-gg/rivet
  2. Checking the skills repo: gh api repos/rivet-dev/skills/contents/skills --jq '.[].name'

Minor Observations

Good practices followed:

  • Using mkdir -p to safely create the directory (won't fail if it exists)
  • Maintaining the selective deletion approach (only removing directories being updated)
  • Keeping the atomic commit-and-push logic intact

Recommendation

LGTM - This is a clean bugfix that resolves the directory structure issue. The code is clear, correct, and maintains consistency with the repository's patterns.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 29, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4065

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@4065

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4065

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4065

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4065

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4065

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4065

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4065

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4065

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4065

commit: 911005e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants