fix: fix active req caculation, add hws metrics

[MasterPtato]

No description provided.

[MasterPtato]

• fix: remove graceful requirement for metrics aggregator #4060
• fix(guard): cache custom serve routes #4059
• fix(gateway): configure cors for error responses #4058
• chore(guard): clean up guard #4057
• fix: fix active req caculation, add hws metrics #4053 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• actor-actions
• actor-actions-vercel
• example-ai-agent
• example-ai-agent-vercel
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-vercel
• example-cloudflare-workers
• example-cloudflare-workers-hono
• cross-actor-actions
• cross-actor-actions-vercel
• example-cursors
• example-cursors-raw-websocket
• example-cursors-raw-websocket-vercel
• example-cursors-vercel
• custom-serverless
• custom-serverless-vercel
• example-sqlite
• example-elysia
• example-elysia-vercel
• example-experimental-durable-streams-ai-agent
• example-experimental-durable-streams-ai-agent-vercel
• hello-world
• hello-world-vercel
• example-hono
• hono-react
• hono-react-vercel
• example-hono-vercel
• example-kitchen-sink
• example-kitchen-sink-vercel
• multi-region
• multi-region-vercel
• native-websockets
• native-websockets-vercel
• next-js
• example-raw-fetch-handler
• example-raw-fetch-handler-vercel
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-raw-websocket-handler-proxy-vercel
• example-raw-websocket-handler-vercel
• example-react
• example-react-vercel
• scheduling
• scheduling-vercel
• state
• state-vercel
• example-stream
• example-stream-vercel
• example-trpc
• example-trpc-vercel

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4053

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4053

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@4053

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4053

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4053

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4053

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4053

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4053

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4053

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4053

commit: 93864b6

[claude]

PR Review: Fix active request calculation and add hibernating websocket metrics

Critical Issues

Compilation Error: Missing Function Definition

Location: engine/packages/pegboard-gateway/src/lib.rs:292

The function init_ns_metrics_exporter is called but never defined. This will cause a compilation failure.

Major Issues

Inconsistent Error Handling Pattern

Location: engine/packages/pegboard-gateway/src/lib.rs:619-700

The error handling for metrics has nested if-else blocks that could be flattened for better readability. When ingress metrics fail, the error is logged. When egress metrics fail, there is a nested condition that makes the code harder to follow.

Recommendation: Flatten the error handling so both metrics operations are independent.

Potential Data Accuracy Issue

Location: engine/packages/pegboard-gateway/src/lib.rs:624-632

Using size_hint() for request body size might not be accurate. The original code used body_bytes.len() which was accurate. This change means metrics might now be less accurate than before.

Code Quality Issues

Critical Bug Fix Without Explanation

Location: engine/packages/pegboard/src/workflows/actor/metrics.rs:67

Changed destroy from true to false. This is a critical logic change that fixes what appears to be a significant bug (actors were being incorrectly marked for destruction). This deserves better documentation and context in the PR description.

Unused Parameter Warning

Location: engine/packages/gasoline/src/db/kv/mod.rs:624

The worker_id parameter is prefixed with underscore but the change is not explained.

Test Coverage

No tests are included. This PR makes significant changes to metrics tracking logic. Consider adding unit tests for hibernating websocket metrics and integration tests verifying the destroy fix.

Summary

Must Fix:

• Add the missing init_ns_metrics_exporter function definition

Should Fix:

• The destroy = false bug fix needs better documentation
• Inconsistent error handling pattern should be cleaned up
• Consider the accuracy trade-off of using size_hint() vs actual body size

Consider:

• Add tests for the metrics changes
• Document the unused worker_id parameter
• Add comments explaining backward compatibility fallbacks