fix: do not emit RMG012 for getter-only target members with queryable projections#2227
Merged
fix: do not emit RMG012 for getter-only target members with queryable projections#2227
Conversation
… projections
When a mapper has a queryable projection and getter-only
properties (expression-bodied or { get; }) incorrectly
triggered RMG012. BuildInitMemberMappings included all
target members in expression context without checking
if they could actually be set.
latonz
requested changes
Apr 11, 2026
Contributor
latonz
left a comment
latonz
left a comment
There was a problem hiding this comment.
Thank you for the contribution! ❤️
latonz
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not emit RMG012 for getter-only target members with queryable projections
Description
When a mapper has a queryable projection and getter-only properties (expression-bodied or { get; }) Mapperly is incorrectly triggering RMG012. BuildInitMemberMappings included all target members in expression context without checking if they could actually be set.
Fixes #2226
Checklist