Skip to content

handling comments in select * from table; #8654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NamanMahor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

handling comments in select * from table; #8654

NamanMahor wants to merge 1 commit into from
+232 −1

Conversation

@NamanMahor
Copy link
Contributor

@NamanMahor NamanMahor commented Jan 16, 2026 •
edited
Loading

PLAT-355: Fix SELECT ALL check in bigquery/warehouse.go (comments brake the check)
Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@NamanMahor NamanMahor requested a review from k-anshul January 16, 2026 06:53
@NamanMahor NamanMahor changed the title handling comments in select * from tab; handling comments in select * from table; Jan 16, 2026
k-anshul
k-anshul approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@k-anshul k-anshul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-anshul k-anshul k-anshul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NamanMahor @k-anshul