[jlouvel]

Stacked on #1537 (base feat/netty-connector). Part of 3.0 M2. This is a breaking change, with no deprecation step.

Summary

The Netty connectors now build Restlet requests and responses directly from Netty messages. The ServerCall/ClientCall and ServerAdapter/ClientAdapter layer is removed.

• NettyServerHelper now extends ServerHelper, and NettyClientHelper now extends ClientHelper. This removes two inheritance levels and should clear the remaining Sonar S110 issues on Replace Jetty with Netty in the core connectors (3.0 milestone 2) #1537.
• Server side: NettyServerCall and the new package-private NettyRequest replace ServerCall, ServerAdapter, HttpRequest and HttpResponse. They keep:
  • lazy header parsing;
  • the org.restlet.http.headers and org.restlet.http.version attributes;
  • TLS client certificates, cipher suite, key size and session ID;
  • X-Forwarded-For support;
  • the entity rules for HEAD, 204, 205, 304 and 1xx responses;
  • the ConnectorService before-send and after-send callbacks.
• Client side: NettyClientCall replaces ClientCall and ClientAdapter. Redirect handling in NettyClientHelper is unchanged.
• Removed: the org.restlet.engine.adapter package and its module-info export, and the "adapter" connector parameter.
• New: Response.getProtocol() and setProtocol(). The HTTP client connector records the protocol version the server replied with (1.1, 2.0 or 3.0). When none was recorded, getProtocol() returns the request's protocol. WrapperResponse delegates both methods, and Response.toString() shows the protocol.
• changes.md is updated (breaking-changes bullet and an enhancement).

Behaviour notes

• If writing a response fails after its headers were already sent, the connection is now closed. Before, the code tried to send a 500 status on top of a partly sent response.

Tests

• New ResponseProtocolTestCase: HTTP/1.1 round trip, fallback to the request protocol on a connection error, wrapper delegation.
• Http2MultiplexingTestCase and Http3TestCase now also check the protocol version on the client response.
• Core module, in a clean worktree: 2,188 tests pass, coverage checks are met, and SpotBugs reports 8 issues, the same count as on Replace Jetty with Netty in the core connectors (3.0 milestone 2) #1537.
• Other modules: the full multi-module build was still running when this PR was opened.

Known issue

ShutdownHookTestCase failed in one core verify run. It checks shutdown timing to within ±200 ms. Run alone, it fails intermittently under load both with and without this change, so it was left out of the full-build run above.

[jlouvel]

Update: the full multi-module install (./mvnw -B -o install) now passes on all 14 modules, with tests, coverage checks and SpotBugs. ShutdownHookTestCase was left out, as noted in the description.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud