fix: hide rich text bubble menu options when inline code is active#3507
Merged
dielduarte merged 1 commit intoMay 13, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 9f49851 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
9b00dc0 to
9f49851
Compare
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: MES-546: Inline code mode blocks other settings
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Hide non-code formatting buttons (Bold, Italic, Underline, Strike, Uppercase) when inline code is active | The diff renders the group containing Bold/Italic/Underline/Strike/Uppercase only in the non-code branch; when isCodeActive is true those items are not rendered. |
| ✅ | Hide the link selector when inline code is active | BubbleMenuLinkSelector is rendered only in the non-code branch; it is omitted in the isCodeActive branch. |
| ✅ | Hide alignment controls (left/center/right) when inline code is active | The alignment BubbleMenuItemGroup is only rendered in the non-code branch and is not present when isCodeActive is true. |
| ✅ | Keep node selector and the inline code button available when inline code is active | When isCodeActive is true the UI renders the NodeSelector and BubbleMenuCode components, preserving access to them. |
Auto-approved: This change conditionally hides rich text formatting options in the bubble menu when inline code is active, using the same patterns already present in the component, with no impact on business logic, data, or infrastructure.
felipefreitag
approved these changes
May 13, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is how it looks like now:
https://www.loom.com/share/f89ba51587f2401997d1ce24800747ea
Essentially we hide all rich text options from the menu when the mark is the inline code
Summary by cubic
Hide rich-text bubble menu options when inline code is active so only the node selector and code toggle are shown. Includes a patch changeset for
@react-email/editor.useEditorStatefrom@tiptap/reactto detecteditor.isActive('code')and render only node selector + code toggle.Written for commit 9f49851. Summary will update on new commits.