Rename command to send_message and move framing to Connection#5
Merged
henrikbjorn merged 2 commits intomasterfrom Mar 13, 2026
Merged
Rename command to send_message and move framing to Connection#5henrikbjorn merged 2 commits intomasterfrom
henrikbjorn merged 2 commits intomasterfrom
Conversation
- Rename Base#command → Base#send_message to clarify intent - Move \n\n framing into Connection#send_message (mirrors read_message) - Inline sendmsg into Outbound#application, delete sendmsg method - Add CommandSocket#application using send_message - Remove Base#write, separate test hook logging from protocol data - Require connection argument (remove unused = nil defaults)
c960657
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base#command→send_messageto clarify it sends a raw message and waits for reply\n\nmessage framing intoConnection#send_message, mirroringread_messageon the read sidesendmsgprotocol intoOutbound#applicationand deletessendmsgmethodCommandSocket#applicationusingsend_messagedirectlyBase#write— test hooks now use a dedicatedlogmethod andhook_logarrayconnectionargument on all listener constructors (removes unused= nildefaults)