Repository navigation
Formatter Bug: All values for parentheses_positions_in_method_declaration are ignored, while ...invocation works #4237
Description
Activity
Can you please attach a sample project with code and settings, reproducing this behavior?
idk if it will work in vscode but try
org.eclipse.jdt.core.formatter.parentheses_positions_in_method_delcarationI was running into a similar problem when setting up Spotless (eclipse) in intellij for a Java project I'm working on and this same problem was driving me crazy.
turns out LLM's are good for something as it pointed out the typo in the official documentation:
Note that there is a typo (delcaration vs. declaration) in the option name. It has to remain, as fixing it would be a breaking change.
nice catch! indeed, vscode-java would reuse the same typo'ed
org.eclipse.jdt.core.formatter.parentheses_positions_in_method_delcarationThis issue has been closed automatically because it needs more information and has not had recent activity. Please reach out if you have or find the answers we need so that we can investigate further.
Problem
There appears to be a persistent bug in the Java formatter where the setting
org.eclipse.jdt.core.formatter.parentheses_positions_in_method_declarationis completely ignored.It seems that all possible values for this setting (e.g.,
separate_lines,preserve_positions, etc.) have no effect on formatting method declarations.This is especially problematic for the
separate_lines_if_wrappedvalue, which is a common and useful setting for code readability. Even when parameters are wrapped onto new lines, the closing parenthesis)is still incorrectly forced onto the same line as the last parameter, directly violating the...if_wrappedrule.Key Evidence of Bug: Inconsistency with
...invocationThe strongest evidence of this bug is the clear inconsistency with its parallel setting, which works perfectly.
Works:
org.eclipse.jdt.core.formatter.parentheses_positions_in_method_invocationseparate_lines_if_wrapped) to method calls.Fails:
org.eclipse.jdt.core.formatter.parentheses_positions_in_method_declarationThis inconsistency proves the bug is isolated specifically to the
..._in_method_declarationimplementation.Related Anomaly (Workaround Glitch)
We also observed a related anomaly that further highlights the bug:
If a user manually inserts a blank line (two newlines) before the closing parenthesis in a method declaration (e.g.,
...status, \n \n ) {), the formatter preserves this structure.This shows the formatter is not applying its own rules consistently. It fails to enforce the
parentheses_positions...rule, but it can be "tricked" into the correct layout by this manual formatting glitch (likely due tojoin_wrapped_lines="false"behavior).Conclusion
This is a bug in the Red Hat Java extension's formatter. The configuration settings for method declarations and invocations should behave identically, but they do not.