Repository navigation
Add PHP 8.1 explicit octal literal (0o / 0O) support - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP 8 lexer defined hexadecimal (
0x) and binary (0b) integer literals but not the PHP 8.1 explicit octal form0o/0O. On such input the scanner emitted0asT_LNUMBERfollowed byo...asT_STRING, producing a spurious parse error, e.g.umask(0o077)failed withunexpected T_STRING, expecting ')'.Change
onumtoken definition and scanner rule ininternal/php8/scanner.rl(base-8 parse,_separators, overflow falls back toT_DNUMBERlike the other bases).internal/php8/scanner.govia ragel.TestExplicitOctalTokens.github.com/TomasVotruba/reco/pkg/tokenimport left inscanner.rlafter the module extraction, so regeneration produces the correctrectorphp/php-parser-in-gopath.Notes
The
scanner.godiff is large because adding a token rule reshapes the generated ragel state machine. Full suite and golangci-lint pass.