fix(reader): update progress during Auto Scroll and put slider overlay values on top - #5676
Merged
Conversation
The scrolled-mode relocate in foliate sits behind a 250ms trailing debounce, and Auto Scroll steps the container every frame, so the timer reset forever and percentage plus time remaining only updated when the scrolling paused. Bump foliate-js so a continuous run of scroll events relocates at most once per second while it lasts, and add a regression test driving a 2.5s scroll burst. Fixes item 2 of #5635. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
While the swipe gesture adjusts speed or brightness the finger sits on or below the edge capsule, hiding a readout placed under the slider. Move the value label to the top and the icon to the bottom in both the Auto Scroll speed overlay and the brightness overlay. Fixes item 3 of #5635. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…x-wait fix Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes items 2 and 3 of #5635 (item 1, jitter, is tracked separately in the issue).
Progress doesn't update while scrolling
The scrolled-mode relocate in the foliate paginator sits behind a 250ms trailing debounce. Auto Scroll steps the container every frame, so the timer reset forever and the percentage / time remaining only updated once scrolling paused. The paginator now forces a relocate at most once per second while an unbroken run of scroll events lasts (readest/foliate-js#72); the trailing debounce still reports the final position. Finger drags keep today's behavior (report on release), matching the preload skip rationale from #4785.
Speed / brightness overlay readout hidden by the finger
While the swipe gesture adjusts the value, the finger sits on or below the edge capsule, hiding the readout under the slider. The value label now sits at the top of the slider and the icon at the bottom, in both the Auto Scroll speed overlay and the brightness overlay, with a DOM-order unit test.
Verification
pnpm test: 9089 passedpnpm test:browser: 357 passed (includes the new regression test)pnpm lintandpnpm format:check: clean🤖 Generated with Claude Code