fix(fixed-layout): restore scrolled PDF annotations - #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the overlay lifecycle for PDF pages in scrolled mode.
The renderer starts the asynchronous
onZoomwork, creates the annotation overlayer, and then PDF.js replaces the text-layer DOM. That leaves saved and synced highlights holding ranges into detached nodes.Refresh the overlayer after
onZoomsettles so annotations are resolved against the current text layer, matching the existing paginated PDF path.Related: readest/readest#5586
Verification is covered by a controlled browser regression test in readest/readest#5719.