Fix flex-growing content sizing in <ScrollView>#1997
Open
sammy-SC wants to merge 1 commit into
Open
Conversation
Summary: X-link: react/react-native#57601 Preserve available height for flex-growing subtrees nested inside scroll content. Apply optimized flex-basis measurement only when a conservative proof shows that the subtree is height-independent and connected to the nearest scroll ancestor through column-stretch layout edges. Keep authored flex-basis, overflow, padding, absolute-positioning, wrapping, and percentage-owner semantics intact across layout and measurement passes. Caching this eligibility proof is intentionally left to a separately gated follow-up. Changelog: [General][Fixed] - Preserve nested `<ScrollView>` sizing during optimized flex-basis measurement Differential Revision: D112353599
|
@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112353599. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: react/react-native#57601
Preserve available height for flex-growing subtrees nested inside scroll content. Apply optimized flex-basis measurement only when a conservative proof shows that the subtree is height-independent and connected to the nearest scroll ancestor through column-stretch layout edges.
Keep authored flex-basis, overflow, padding, absolute-positioning, wrapping, and percentage-owner semantics intact across layout and measurement passes. Caching this eligibility proof is intentionally left to a separately gated follow-up.
Changelog:
[General][Fixed] - Preserve nested
<ScrollView>sizing during optimized flex-basis measurementDifferential Revision: D112353599