Skip to content

fix(iOS) - Prevent SwiftUI based filter from insetting content by the safe area #58349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intergalacticspacehighway wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

fix(iOS) - Prevent SwiftUI based filter from insetting content by the safe area #58349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,7 +1746,13 @@ - (NSString *)componentViewName_DO_NOT_USE_THIS_IS_BROKEN

- (BOOL)styleNeedsSwiftUIContainer
{
if (!_props->filter.empty()) {
if (_props->filter.empty()) {
return NO;
}

// A filter must not affect layout, but UIHostingController insets its content by the safe area.
// To disable the insets we use `safeAreaRegions` which is only available in iOS 16.4 and tvOS 16.4.
if (@available(iOS 16.4, tvOS 16.4, *)) {
for (const auto &primitive : _props->filter) {
if (primitive.type == FilterType::Blur || primitive.type == FilterType::Grayscale ||
primitive.type == FilterType::DropShadow || primitive.type == FilterType::Saturate ||
Expand All @@ -1755,6 +1761,7 @@ - (BOOL)styleNeedsSwiftUIContainer
}
}
}

return NO;
}

Expand Down
9 changes: 7 additions & 2 deletions packages/react-native/ReactApple/RCTSwiftUI/RCTSwiftUIContainerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@ import UIKit

@objc public override init() {
super.init()
hostingController = UIHostingController(rootView: SwiftUIContainerView(viewModel: containerViewModel))
guard let view = hostingController?.view else {
let controller = UIHostingController(rootView: SwiftUIContainerView(viewModel: containerViewModel))
if #available(iOS 16.4, tvOS 16.4, *) {
// Disable implicit safe area insets or else the view is shifted by the safe area insets
controller.safeAreaRegions = []
}
hostingController = controller
guard let view = controller.view else {
return
}
view.backgroundColor = .clear
Expand Down
Loading