Skip to content

Fix stack-use-after-return in TaskDispatchThread Android ctor #57629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Fix stack-use-after-return in TaskDispatchThread Android ctor #57629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/react-native/ReactCxxPlatform/react/threading/TaskDispatchThread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,12 @@ TaskDispatchThread::TaskDispatchThread(
int priorityOffset) noexcept
: threadName_(threadName) {
#ifdef ANDROID
// Attaches the thread to JVM just in case anything calls out to Java
thread_ = std::thread([&]() {
facebook::jni::ThreadScope::WithClassLoader([&]() {
// Attaches the thread to JVM just in case anything calls out to Java.
// Capture priorityOffset by value: it is a constructor parameter whose
// storage dies when the constructor returns, and the thread body reads it
// asynchronously.
thread_ = std::thread([this, priorityOffset]() {
facebook::jni::ThreadScope::WithClassLoader([this, priorityOffset]() {
int result = setpriority(
PRIO_PROCESS,
static_cast<pid_t>(::syscall(SYS_gettid)),
Expand Down
Loading