Open
Conversation
|
- Add missing getMetadataFor method to DocSaver class to implement GetsMetadataProtocol - Remove unnecessary try keyword from DocumentMetadataBuilder.build() call - Add missing LocalCopyResponse.swift and FileOperations.swift files for macOS - All Swift files now compile without type errors
vonovak
requested changes
Jul 26, 2025
Author
|
Ok, but really not, there are enough differences between platforms that IOS
doesn't work on MacOS, and my latest is initially working on MacOS ...
The latest commit uses the native MacOS (not catalyst)
…On Sat, Jul 26, 2025 at 6:54 AM Vojtech Novak ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I welcome macOS support, but my initial impression is that there's a lot
of duplication with the ios implementation at this point.
This needs to be refactored so that there is very little duplication
across the two platforms.
—
Reply to this email directly, view it on GitHub
<#849 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEHN3KWKYBUVXMZ6MP5GULL3KNM7ZAVCNFSM6AAAAACCC4XO66VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJYGAYDIMBXGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added macos support