Feature/rrd prof updated by Abhinavpv28 · Pull Request #183 · rdkcentral/remote_debugger

Abhinavpv28 · 2026-04-10T09:13:59Z

No description provided.

Added helper functions for profile data processing.

Copilot

Pull request overview

This PR adds RBUS support for setting and retrieving “profile data” for the RDK Remote Debugger, backed by parsing /etc/rrd/remote_debugger.json and a persisted selected category.

Changes:

Introduces new TR-181/RBUS parameter strings for setProfileData and getProfileData, plus a persisted “profile category” selection.
Registers/unregisters RBUS data elements and implements RBUS set/get handlers.
Adds cJSON-based helper functions to read and transform the profile JSON into response payloads.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
`src/rrdInterface.h`	Adds new profile RBUS parameter constants, includes cJSON, and declares new handlers/helpers.
`src/rrdInterface.c`	Implements category persistence, registers RBUS data elements, and adds RBUS handlers + JSON processing helpers.

src/rrdInterface.c

src/rrdInterface.h

src/rrdInterface.c

Copilot · 2026-04-10T09:22:15Z

src/rrdInterface.c

+        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s not found\n", 
+            __FUNCTION__, __LINE__, category_name);
+        return cJSON_Print(cJSON_CreateArray());
+    }
+
+    if (!has_direct_commands(category)) {
+        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s has nested structure, returning empty\n", 
+            __FUNCTION__, __LINE__, category_name);
+        return cJSON_Print(cJSON_CreateArray());


get_specific_category_json returns cJSON_Print(cJSON_CreateArray()) in the early-exit paths. This leaks the newly created cJSON array object because it is never deleted. Create the empty array in a variable, print it, then cJSON_Delete it before returning the printed string.

Suggested change

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s not found\n",

__FUNCTION__, __LINE__, category_name);

return cJSON_Print(cJSON_CreateArray());

}

if (!has_direct_commands(category)) {

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s has nested structure, returning empty\n",

__FUNCTION__, __LINE__, category_name);

return cJSON_Print(cJSON_CreateArray());

cJSON *emptyArray = cJSON_CreateArray();

char *result_str = NULL;

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s not found\n",

__FUNCTION__, __LINE__, category_name);

result_str = cJSON_Print(emptyArray);

cJSON_Delete(emptyArray);

return result_str;

}

if (!has_direct_commands(category)) {

cJSON *emptyArray = cJSON_CreateArray();

char *result_str = NULL;

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s has nested structure, returning empty\n",

__FUNCTION__, __LINE__, category_name);

result_str = cJSON_Print(emptyArray);

cJSON_Delete(emptyArray);

return result_str;

Copilot · 2026-04-10T09:22:15Z

src/rrdInterface.c

+    jsonBuffer[bytesRead] = '\0';
+    fclose(fp);
+
+    *file_size = fileSz;


read_profile_json_file doesn’t verify that fread read the full file (it may return short reads), but still returns the buffer and reports *file_size = fileSz. This can lead to truncated/invalid JSON being parsed with no clear error. Check bytesRead == (size_t)fileSz (or handle partial reads) and set *file_size to the actual bytes read.

Suggested change

jsonBuffer[bytesRead] = '\0';

fclose(fp);

*file_size = fileSz;

if (bytesRead != (size_t)fileSz) {

jsonBuffer[bytesRead] = '\0';

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to read complete profile file from %s (expected %ld bytes, read %zu bytes)\n", __FUNCTION__, __LINE__, filename, fileSz, bytesRead);

fclose(fp);

free(jsonBuffer);

return NULL;

}

jsonBuffer[bytesRead] = '\0';

fclose(fp);

*file_size = (long)bytesRead;

Copilot · 2026-04-10T09:22:16Z

src/rrdInterface.c

+        return RBUS_ERROR_INVALID_INPUT;
+    }
+
+    const char *filename = "/etc/rrd/remote_debugger.json";


This hard-codes the profile JSON path as "/etc/rrd/remote_debugger.json", but the project already defines RRD_JSON_FILE in rrdCommon.h. Using the shared constant avoids duplication and keeps future path changes consistent.

Suggested change

const char *filename = "/etc/rrd/remote_debugger.json";

const char *filename = RRD_JSON_FILE;

Copilot · 2026-04-10T09:22:16Z

src/rrdInterface.c

+rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusSetHandlerOptions_t* opts)
+{
+    (void)handle;
+    (void)opts;
+


New behavior is introduced via rrd_SetHandler/rrd_GetHandler (persisting the selected category and generating RBUS responses based on /etc/rrd/remote_debugger.json), but there are currently no unit tests covering these paths in src/unittest/rrdUnitTestRunner.cpp (which already tests other rrdInterface.c helpers like checkAppendRequest). Adding tests for category persistence, JSON parsing, and the "all" vs specific-category responses would help prevent regressions.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Copilot · 2026-04-10T09:38:58Z

src/rrdInterface.c

+    size_t bytesRead = fread(jsonBuffer, 1U, (size_t)fileSz, fp);
+    jsonBuffer[bytesRead] = '\0';
+    fclose(fp);
+
+    *file_size = fileSz;
+    return jsonBuffer;


read_profile_json_file doesn’t validate that fread read the expected number of bytes. If bytesRead != fileSz (short read / I/O error), the caller may parse truncated JSON and *file_size will be inaccurate. Check for short reads (bytesRead == (size_t)fileSz), handle ferror(fp), and fail/cleanup on mismatch.

Copilot · 2026-04-10T09:38:59Z

src/rrdInterface.c

+    if (ret != 0) {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS unregDataElements failed with error: %d\n", __FUNCTION__, __LINE__, ret);


rbus_unregDataElements is checked against ret != 0 here, while rbus_regDataElements above uses ret != RBUS_ERROR_SUCCESS. For consistency (and in case success isn’t exactly 0), compare against RBUS_ERROR_SUCCESS and log rbusError_ToString((rbusError_t)ret) like other RBUS paths do.

Suggested change

if (ret != 0) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS unregDataElements failed with error: %d\n", __FUNCTION__, __LINE__, ret);

if (ret != RBUS_ERROR_SUCCESS) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS unregDataElements failed with error: %d(%s)\n", __FUNCTION__, __LINE__, ret, rbusError_ToString((rbusError_t)ret));

Copilot · 2026-04-10T09:38:59Z

src/rrdInterface.c

+rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusSetHandlerOptions_t* opts)
+{
+    (void)handle;
+    (void)opts;
+
+    char const* propertyName = rbusProperty_GetName(prop);
+    rbusValue_t value = rbusProperty_GetValue(prop);
+    rbusValueType_t type = rbusValue_GetType(value);


rrd_SetHandler/rrd_GetHandler (and the helper functions below) introduce new RBUS handler APIs/types (rbusProperty_t, rbusGetHandlerOptions_t, etc.). The unit test build compiles rrdInterface.c with -DGTEST_ENABLE and does not define these RBUS types in its mocks, so this will fail to compile there. Wrap these handler implementations in #if !defined(GTEST_ENABLE) (matching the header) or extend the gtest RBUS mocks to include the required types/APIs.

Copilot · 2026-04-10T09:38:59Z

src/rrdInterface.c

+rbusError_t rrd_GetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusGetHandlerOptions_t* opts)
+{
+    (void)handle;
+    (void)opts;
+
+    char const* propertyName = rbusProperty_GetName(prop);
+    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Get handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);
+
+    if(strcmp(propertyName, RRD_GET_PROFILE_EVENT) != 0) {
+        return RBUS_ERROR_INVALID_INPUT;
+    }
+
+    const char *filename = "/etc/rrd/remote_debugger.json";
+    long file_size;
+
+    // Read JSON file
+    char *jsonBuffer = read_profile_json_file(filename, &file_size);
+    if (!jsonBuffer) {
+        return RBUS_ERROR_BUS_ERROR;
+    }
+
+    // Parse JSON
+    cJSON *json = cJSON_Parse(jsonBuffer);
+    if (!json) {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to parse JSON from %s\n", __FUNCTION__, __LINE__, filename);
+        free(jsonBuffer);
+        return RBUS_ERROR_BUS_ERROR;
+    }
+
+    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: JSON parsed successfully, processing categories\n", __FUNCTION__, __LINE__);
+
+    // Generate appropriate JSON response
+    char *result_str = NULL;
+    if (strlen(RRDProfileCategory) == 0 || strcmp(RRDProfileCategory, "all") == 0) {
+        result_str = get_all_categories_json(json);
+    } else {
+        result_str = get_specific_category_json(json, RRDProfileCategory);
+    }


New profile-data behavior (category persistence + JSON category listing + rrd_GetHandler response formatting) is introduced here but there are no corresponding unit tests in src/unittest/rrdUnitTestRunner.cpp (that file already tests other rrdInterface.c helpers like checkAppendRequest). Adding focused tests for: (1) “all” vs specific category output, (2) nested-category returning empty, and (3) missing/invalid JSON file handling would help prevent regressions.

Copilot · 2026-04-10T09:38:59Z

src/rrdInterface.c

+    const char *filename = "/etc/rrd/remote_debugger.json";
+    long file_size;
+


file_size is set via read_profile_json_file but never used afterwards, which can trigger an unused-variable warning depending on compiler flags. Either remove file_size (and the out-parameter) if not needed, or use it (e.g., for logging/validation).

Removed mock implementations for profile handler functions when GTEST_ENABLE is defined.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

src/unittest/mocks/Client_Mock.cpp:231

rbusValue_Release function-pointer variable is defined twice in this file (once around line 211 and again at line 229). This will fail to compile due to a redefinition error; remove the duplicate definition and keep a single initialization.

rbusValueType_t (*rbusValue_GetType)(rbusValue_t) = &RBusApiWrapper::rbusValue_GetType;
char const* (*rbusValue_GetString)(rbusValue_t, int*) = &RBusApiWrapper::rbusValue_GetString;
void (*rbusProperty_SetValue)(rbusProperty_t, rbusValue_t) = &RBusApiWrapper::rbusProperty_SetValue;
void (*rbusValue_Release)(rbusValue_t) = &RBusApiWrapper::rbusValue_Release;

void (*rbusValue_Release)(rbusValue_t) = &RBusApiWrapper::rbusValue_Release;

/* -------- RFC ---------------*/
SetParamInterface *SetParamWrapper::impl = nullptr;

SetParamWrapper::SetParamWrapper() {}

void SetParamWrapper::setImpl(SetParamInterface *newImpl)
{
    EXPECT_TRUE((nullptr == impl) || (nullptr == newImpl));
    impl = newImpl;
}

void SetParamWrapper::clearImpl()
{
    impl = nullptr;
}

tr181ErrorCode_t SetParamWrapper::setParam(char *arg1, const char *arg2, const char *arg3)

src/unittest/mocks/Client_Mock.cpp:228

rrd_SetHandler / rrd_GetHandler are defined here under GTEST_ENABLE, but they are also implemented in src/rrdInterface.c in this PR. With the unit-test runner including both Client_Mock.cpp and rrdInterface.c into the same translation unit, this causes duplicate symbol/ODR redefinition build failures. Remove these mock definitions (or compile-guard the real ones) so only one definition exists in tests.

void (*rbusValue_Release)(rbusValue_t) = &RBusApiWrapper::rbusValue_Release;

/* -------- RFC ---------------*/
SetParamInterface *SetParamWrapper::impl = nullptr;

SetParamWrapper::SetParamWrapper() {}

void SetParamWrapper::setImpl(SetParamInterface *newImpl)
{
    EXPECT_TRUE((nullptr == impl) || (nullptr == newImpl));
    impl = newImpl;
}

void SetParamWrapper::clearImpl()
{
    impl = nullptr;

Copilot · 2026-04-10T09:52:31Z

src/rrdInterface.h

 #include "rrdCommon.h"
 #if !defined(GTEST_ENABLE)
 #include "rbus.h"
+#include <cjson/cJSON.h>


#include <cjson/cJSON.h> is inconsistent with the rest of the codebase, which includes cJSON as "cJSON.h" (e.g., src/rrdJsonParser.h:29, src/rrdCommandSanity.h:28). Using a different include path risks breaking builds depending on include search paths; align this include with the existing convention or ensure the build explicitly provides the cjson/cJSON.h path.

Suggested change

#include <cjson/cJSON.h>

#include "cJSON.h"

Copilot · 2026-04-10T09:52:32Z

src/rrdInterface.h

+// RDK Remote Debugger profile data parameter definitions
+#define RRD_SET_PROFILE_EVENT "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.RDKRemoteDebugger.setProfileData"
+#define RRD_GET_PROFILE_EVENT "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.RDKRemoteDebugger.getProfileData"
+#define RRD_PROFILE_CATEGORY_FILE "/tmp/rrd_profile_category"


The profile category is persisted under /tmp (RRD_PROFILE_CATEGORY_FILE). If this process runs with elevated privileges, writing to a fixed path in a world-writable directory via fopen("w") is vulnerable to symlink/hardlink attacks (clobbering arbitrary files). Consider storing this state under a protected directory (e.g., /var/run//opt) or use a secure open() pattern (O_NOFOLLOW, O_CREAT|O_TRUNC, 0600) and then fdopen().

Suggested change

#define RRD_PROFILE_CATEGORY_FILE "/tmp/rrd_profile_category"

#define RRD_PROFILE_CATEGORY_FILE "/var/run/rrd_profile_category"

Copilot · 2026-04-10T09:52:32Z

src/rrdInterface.c

+// Global storage for profile category
+char RRDProfileCategory[256] = "all";


RRDProfileCategory is a non-static global with external linkage, but it is only used within this translation unit. Leaving it non-static needlessly exports a global symbol and increases the risk of name collisions at link time. Make it static (and consider keeping it near the handlers that use it).

Suggested change

// Global storage for profile category

char RRDProfileCategory[256] = "all";

// File-local storage for profile category

static char RRDProfileCategory[256] = "all";

Copilot · 2026-04-10T09:52:32Z

src/rrdInterface.c

+rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusSetHandlerOptions_t* opts)
+{
+    (void)handle;
+    (void)opts;
+
+    char const* propertyName = rbusProperty_GetName(prop);
+    rbusValue_t value = rbusProperty_GetValue(prop);
+    rbusValueType_t type = rbusValue_GetType(value);
+
+    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Set handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);
+
+    if(strcmp(propertyName, RRD_SET_PROFILE_EVENT) == 0) {
+        if (type == RBUS_STRING) {
+            const char* str = rbusValue_GetString(value, NULL);
+            if(strlen(str) > 255) {
+                RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: String too long for setProfileData\n", __FUNCTION__, __LINE__);
+                return RBUS_ERROR_INVALID_INPUT;
+            }
+
+            strncpy(RRDProfileCategory, str, sizeof(RRDProfileCategory)-1);
+            RRDProfileCategory[sizeof(RRDProfileCategory)-1] = '\0';
+            RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: setProfileData value: %s\n", __FUNCTION__, __LINE__, RRDProfileCategory);
+
+            // Store the category selection to file
+            if(save_profile_category() != 0) {


New RBUS set/get handlers and JSON profile processing logic are introduced here, but there are currently no unit tests covering: (1) setting the category (including file persistence), (2) retrieving "all" vs a specific category, and (3) error paths (missing/invalid JSON, oversized category). Since src/unittest/rrdUnitTestRunner.cpp already provides extensive coverage for other rrdInterface.c behavior, add focused tests for these new handlers to prevent regressions.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Copilot · 2026-04-10T11:03:10Z

src/rrdInterface.c

+    cJSON *category = cJSON_GetObjectItem(json, category_name);
+    if (!category || !cJSON_IsObject(category)) {
+        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Category %s not found\n", 
+            __FUNCTION__, __LINE__, category_name);
+        return cJSON_Print(cJSON_CreateArray());
+    }


get_specific_category_json returns cJSON_Print(cJSON_CreateArray()) on error paths. This leaks the temporary array object because it is never deleted. Create the array, print it, then cJSON_Delete it before returning (or reuse a shared helper for empty-array responses).

Copilot · 2026-04-10T11:03:11Z

src/rrdInterface.c

+    if (!json_str) {
+        return RBUS_ERROR_BUS_ERROR;
+    }
+
+    rbusValue_t rbusValue;
+    rbusValue_Init(&rbusValue);
+    rbusValue_SetString(rbusValue, json_str);
+    rbusProperty_SetValue(prop, rbusValue);
+    rbusValue_Release(rbusValue);
+


set_rbus_response ignores the return codes from rbusValue_Init / rbusValue_SetString. If init fails, rbusValue may be uninitialized and subsequent calls will misbehave. Capture and check these results and return an appropriate rbusError_t on failure.

Suggested change

if (!json_str) {

return RBUS_ERROR_BUS_ERROR;

}

rbusValue_t rbusValue;

rbusValue_Init(&rbusValue);

rbusValue_SetString(rbusValue, json_str);

rbusProperty_SetValue(prop, rbusValue);

rbusValue_Release(rbusValue);

rbusError_t error;

rbusValue_t rbusValue = NULL;

if (!json_str) {

return RBUS_ERROR_BUS_ERROR;

}

error = rbusValue_Init(&rbusValue);

if (error != RBUS_ERROR_SUCCESS) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: rbusValue_Init failed with error %d\n", __FUNCTION__, __LINE__, error);

return error;

}

error = rbusValue_SetString(rbusValue, json_str);

if (error != RBUS_ERROR_SUCCESS) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: rbusValue_SetString failed with error %d\n", __FUNCTION__, __LINE__, error);

rbusValue_Release(rbusValue);

return error;

}

rbusProperty_SetValue(prop, rbusValue);

rbusValue_Release(rbusValue);

Copilot · 2026-04-10T11:03:11Z

src/rrdInterface.c

 #if !defined(GTEST_ENABLE)
    ret = rbusEvent_UnsubscribeEx(rrdRbusHandle, subscriptions, 3);
    if (ret != 0)
    {
        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS Unsubscribe EventHandler for RRD failed!!! \n", __FUNCTION__, __LINE__);
        return ret;
    }



On rbusEvent_UnsubscribeEx failure, this function returns early and skips unregistering the newly-added profile data elements (and also skips rbus_close). Consider doing best-effort cleanup (attempt rbus_unregDataElements and rbus_close) even when event unsubscription fails, and return the first error encountered.

Copilot · 2026-04-10T11:03:11Z

src/rrdInterface.h

 int RRD_unsubscribe(void);
+rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t property, rbusSetHandlerOptions_t* opts);
+rbusError_t rrd_GetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusGetHandlerOptions_t* opts);


rrd_SetHandler / rrd_GetHandler are declared unconditionally but their parameter types come from RBUS headers, which are excluded when GTEST_ENABLE is defined. This makes rrdInterface.h non-self-contained for GTest builds unless callers include the mocks first. Wrap these declarations in #if !defined(GTEST_ENABLE) (like the other RBUS-only declarations) or provide forward declarations/typedefs so the header compiles on its own.

Suggested change

int RRD_unsubscribe(void);

rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t property, rbusSetHandlerOptions_t* opts);

rbusError_t rrd_GetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusGetHandlerOptions_t* opts);

int RRD_unsubscribe(void);

#if !defined(GTEST_ENABLE)

rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t property, rbusSetHandlerOptions_t* opts);

rbusError_t rrd_GetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusGetHandlerOptions_t* opts);

#endif

Copilot · 2026-04-10T11:03:12Z

src/rrdInterface.c

+    (void)handle;
+    (void)opts;
+
+    char const* propertyName = rbusProperty_GetName(prop);
+    rbusValue_t value = rbusProperty_GetValue(prop);
+    rbusValueType_t type = rbusValue_GetType(value);
+
+    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Set handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);
+
+    if(strcmp(propertyName, RRD_SET_PROFILE_EVENT) == 0) {
+        if (type == RBUS_STRING) {
+            const char* str = rbusValue_GetString(value, NULL);


New RBUS provider handlers (rrd_SetHandler/rrd_GetHandler) add non-trivial behavior (persisting category selection, reading/parsing /etc/rrd/remote_debugger.json, building JSON responses) but there are no corresponding unit tests in the existing GTest suite. Add tests that cover: valid/invalid set input, missing/invalid JSON file, "all" vs specific category selection, and RBUS value init/set failures.

Suggested change

(void)handle;

(void)opts;

char const* propertyName = rbusProperty_GetName(prop);

rbusValue_t value = rbusProperty_GetValue(prop);

rbusValueType_t type = rbusValue_GetType(value);

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Set handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);

if(strcmp(propertyName, RRD_SET_PROFILE_EVENT) == 0) {

if (type == RBUS_STRING) {

const char* str = rbusValue_GetString(value, NULL);

rbusValue_t value;

rbusValueType_t type;

char const* propertyName;

(void)handle;

(void)opts;

if(prop == NULL) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: NULL property passed to set handler\n", __FUNCTION__, __LINE__);

return RBUS_ERROR_INVALID_INPUT;

}

propertyName = rbusProperty_GetName(prop);

if(propertyName == NULL) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: NULL property name in set handler\n", __FUNCTION__, __LINE__);

return RBUS_ERROR_INVALID_INPUT;

}

value = rbusProperty_GetValue(prop);

if(value == NULL) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: NULL property value for [%s]\n", __FUNCTION__, __LINE__, propertyName);

return RBUS_ERROR_INVALID_INPUT;

}

type = rbusValue_GetType(value);

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Set handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);

if(strcmp(propertyName, RRD_SET_PROFILE_EVENT) == 0) {

if (type == RBUS_STRING) {

const char* str = rbusValue_GetString(value, NULL);

if(str == NULL) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: NULL string for setProfileData\n", __FUNCTION__, __LINE__);

return RBUS_ERROR_INVALID_INPUT;

}

github-actions · 2026-04-10T11:27:34Z

Code Coverage Summary

                               Total:|80.2%   5327|95.9%  1326|    -      0

Co-authored-by: Copilot <[email protected]>

github-actions · 2026-04-10T11:34:07Z

Code Coverage Summary

                               Total:|80.2%   5327|95.9%  1326|    -      0

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Copilot · 2026-04-10T11:41:21Z

src/rrdInterface.c

+    // Register RBUS data elements for profile data provider
+    ret = rbus_regDataElements(rrdRbusHandle, 2, profileDataElements);
+    if (ret != RBUS_ERROR_SUCCESS) {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS regDataElements failed with error: %d\n", __FUNCTION__, __LINE__, ret);
+    } else {
+        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: SUCCESS: RBUS profile data elements registered\n", __FUNCTION__, __LINE__);
+    }
+
    webconfigFrameworkInit();
    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: ...Exiting.. \n", __FUNCTION__, __LINE__);
    return ret;


RRD_subscribe() overwrites ret with the result of rbus_regDataElements() and then returns it. This can mask an earlier RBUS event subscription failure (e.g., rbusEvent_SubscribeEx fails but rbus_regDataElements succeeds, returning success). Consider preserving the first failure (or combining errors) and avoid reusing ret for unrelated operations.

Copilot · 2026-04-10T11:41:21Z

src/rrdInterface.c

+// Global storage for profile category
+char RRDProfileCategory[256] = "all";
+#define MAX_PROFILE_JSON_SIZE 32768
+
+// Helper functions for profile category file-based storage
+int load_profile_category(void) {
+    FILE *fp = fopen(RRD_PROFILE_CATEGORY_FILE, "r");
+    if (fp) {
+        if (fgets(RRDProfileCategory, sizeof(RRDProfileCategory), fp)) {
+            // Remove trailing newline
+            char *newline = strchr(RRDProfileCategory, '\n');
+            if (newline) *newline = '\0';
+            fclose(fp);
+            return 0;
+        }
+        fclose(fp);
+    }
+    // Default to "all" if file doesn't exist or read fails
+    strncpy(RRDProfileCategory, "all", sizeof(RRDProfileCategory) - 1);
+    RRDProfileCategory[sizeof(RRDProfileCategory) - 1] = '\0';
+    return -1;
+}
+
+int save_profile_category(void) {
+    FILE *fp = fopen(RRD_PROFILE_CATEGORY_FILE, "w");
+    if (fp) {
+        fprintf(fp, "%s\n", RRDProfileCategory);
+        fclose(fp);
+        return 0;
+    }
+    return -1;
+}


These helper functions and globals (RRDProfileCategory, load_profile_category, save_profile_category) are not static and appear to be used only within rrdInterface.c (no other references in src/). Making them static avoids exporting internal symbols and reduces the chance of name collisions at link time.

Copilot · 2026-04-10T11:41:21Z

src/rrdInterface.c

+rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusSetHandlerOptions_t* opts)
+{
+    (void)handle;
+    (void)opts;
+
+    char const* propertyName = rbusProperty_GetName(prop);
+    rbusValue_t value = rbusProperty_GetValue(prop);
+    rbusValueType_t type = rbusValue_GetType(value);
+
+    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Set handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);
+
+    if(strcmp(propertyName, RRD_SET_PROFILE_EVENT) == 0) {
+        if (type == RBUS_STRING) {
+            const char* str = rbusValue_GetString(value, NULL);
+            if(strlen(str) > 255) {
+                RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: String too long for setProfileData\n", __FUNCTION__, __LINE__);
+                return RBUS_ERROR_INVALID_INPUT;
+            }
+
+            strncpy(RRDProfileCategory, str, sizeof(RRDProfileCategory)-1);
+            RRDProfileCategory[sizeof(RRDProfileCategory)-1] = '\0';
+            RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: setProfileData value: %s\n", __FUNCTION__, __LINE__, RRDProfileCategory);
+
+            // Store the category selection to file
+            if(save_profile_category() != 0) {
+                RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to store profile category\n", __FUNCTION__, __LINE__);
+                return RBUS_ERROR_BUS_ERROR;
+            }
+
+            RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "[%s:%d]: Successfully set profile category to: %s\n", __FUNCTION__, __LINE__, RRDProfileCategory);
+            return RBUS_ERROR_SUCCESS;
+        } else {
+            RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Invalid type for setProfileData\n", __FUNCTION__, __LINE__);
+            return RBUS_ERROR_INVALID_INPUT;
+        }
+    }
+
+    return RBUS_ERROR_INVALID_INPUT;
+}


Unit tests appear to exist for other rrdInterface.c functions (e.g., checkAppendRequest in src/unittest/rrdUnitTestRunner.cpp), but there are no tests covering the newly added RBUS profile handlers (rrd_SetHandler/rrd_GetHandler) and JSON response shaping. Adding tests for valid/invalid category set, missing/invalid JSON file, and category filtering would help prevent regressions.

Copilot · 2026-04-10T11:41:22Z

src/unittest/Makefile.am


 # Define the compiler flags
-COMMON_CXXFLAGS = -frtti -fprofile-arcs -ftest-coverage
+COMMON_CXXFLAGS = -frtti -fprofile-arcs -ftest-coverage -fpermissive


Adding -fpermissive relaxes C++ type checking and can hide real errors in the unit test build (e.g., invalid conversions that should fail). It would be better to address the underlying issues (or compile C sources as C rather than including .c files in a C++ TU) and keep the test build strict.

Suggested change

COMMON_CXXFLAGS = -frtti -fprofile-arcs -ftest-coverage -fpermissive

COMMON_CXXFLAGS = -frtti -fprofile-arcs -ftest-coverage

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Copilot · 2026-04-10T12:29:44Z

src/rrdInterface.c

+bool has_direct_commands(cJSON *category)
+{
+    cJSON *item = NULL;
+    cJSON_ArrayForEach(item, category) {
+        if (cJSON_IsObject(item)) {
+            cJSON *commands = cJSON_GetObjectItem(item, "Commands");
+            if (commands && cJSON_IsString(commands)) {
+                return true;


has_direct_commands() is called with nullptr in the unit tests, but the implementation iterates unconditionally; cJSON_ArrayForEach on a null pointer will crash. Add an explicit if(!category) return false; guard before iterating.

Copilot · 2026-04-10T12:29:44Z

src/rrdInterface.c

+    FILE *fp = fopen(filename, "rb");
+    if (!fp) {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Unable to read profile file from %s\n", __FUNCTION__, __LINE__, filename);
+        return NULL;
+    }
+
+    fseek(fp, 0L, SEEK_END);
+    long fileSz = ftell(fp);
+    rewind(fp);
+
+    if (fileSz <= 0 || fileSz >= MAX_PROFILE_JSON_SIZE) {
+        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Invalid file size: %ld\n", __FUNCTION__, __LINE__, fileSz);
+        fclose(fp);
+        return NULL;
+    }
+
+    char *jsonBuffer = malloc(fileSz + 1);
+    if (!jsonBuffer) {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Memory allocation failed for JSON buffer\n", __FUNCTION__, __LINE__);
+        fclose(fp);
+        return NULL;
+    }
+
+    size_t bytesRead = fread(jsonBuffer, 1U, (size_t)fileSz, fp);
+    jsonBuffer[bytesRead] = '\0';
+    fclose(fp);
+


read_profile_json_file() does not validate filename or file_size before using them (fopen on nullptr / logging %s with nullptr / dereferencing file_size). Add early validation, ensure *file_size is set to 0 on all failure paths, and consider checking fseek/ftell/fread results (e.g., bytesRead == fileSz) before returning a buffer.

Suggested change

FILE *fp = fopen(filename, "rb");

if (!fp) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Unable to read profile file from %s\n", __FUNCTION__, __LINE__, filename);

return NULL;

}

fseek(fp, 0L, SEEK_END);

long fileSz = ftell(fp);

rewind(fp);

if (fileSz <= 0 || fileSz >= MAX_PROFILE_JSON_SIZE) {

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Invalid file size: %ld\n", __FUNCTION__, __LINE__, fileSz);

fclose(fp);

return NULL;

}

char *jsonBuffer = malloc(fileSz + 1);

if (!jsonBuffer) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Memory allocation failed for JSON buffer\n", __FUNCTION__, __LINE__);

fclose(fp);

return NULL;

}

size_t bytesRead = fread(jsonBuffer, 1U, (size_t)fileSz, fp);

jsonBuffer[bytesRead] = '\0';

fclose(fp);

if (!file_size) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: file_size is NULL\n", __FUNCTION__, __LINE__);

return NULL;

}

*file_size = 0;

if (!filename) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: filename is NULL\n", __FUNCTION__, __LINE__);

return NULL;

}

FILE *fp = fopen(filename, "rb");

if (!fp) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Unable to read profile file from %s\n", __FUNCTION__, __LINE__, filename);

return NULL;

}

if (fseek(fp, 0L, SEEK_END) != 0) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to seek to end of profile file %s\n", __FUNCTION__, __LINE__, filename);

fclose(fp);

return NULL;

}

long fileSz = ftell(fp);

if (fileSz < 0) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to get profile file size for %s\n", __FUNCTION__, __LINE__, filename);

fclose(fp);

return NULL;

}

if (fseek(fp, 0L, SEEK_SET) != 0) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to rewind profile file %s\n", __FUNCTION__, __LINE__, filename);

fclose(fp);

return NULL;

}

if (fileSz <= 0 || fileSz >= MAX_PROFILE_JSON_SIZE) {

RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Invalid file size: %ld\n", __FUNCTION__, __LINE__, fileSz);

fclose(fp);

return NULL;

}

char *jsonBuffer = malloc(fileSz + 1);

if (!jsonBuffer) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Memory allocation failed for JSON buffer\n", __FUNCTION__, __LINE__);

fclose(fp);

return NULL;

}

size_t bytesRead = fread(jsonBuffer, 1U, (size_t)fileSz, fp);

if (bytesRead != (size_t)fileSz) {

RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to read complete profile file %s\n", __FUNCTION__, __LINE__, filename);

free(jsonBuffer);

fclose(fp);

return NULL;

}

jsonBuffer[fileSz] = '\0';

fclose(fp);

Copilot · 2026-04-10T12:29:44Z

src/rrdInterface.c

+char* get_all_categories_json(cJSON* json)
+{
+    cJSON *response = cJSON_CreateObject();
+
+    cJSON *category = NULL;
+    cJSON_ArrayForEach(category, json) {
+        if (cJSON_IsObject(category) && category->string) {
+            if (has_direct_commands(category)) {


get_all_categories_json() assumes json is non-null; calling it with nullptr will crash in cJSON_ArrayForEach. Either return an empty JSON object string for null input or return nullptr consistently and update callers/tests accordingly.

Copilot · 2026-04-10T12:29:45Z

src/rrdInterface.c

+rbusError_t set_rbus_response(rbusProperty_t prop, const char* json_str)
+{
+    if (!json_str) {
+        return RBUS_ERROR_BUS_ERROR;
+    }
+
+    rbusValue_t rbusValue;
+    rbusValue_Init(&rbusValue);
+    rbusValue_SetString(rbusValue, json_str);
+    rbusProperty_SetValue(prop, rbusValue);
+    rbusValue_Release(rbusValue);
+


set_rbus_response() only checks json_str; if prop is nullptr (as in the unit test), rbusProperty_SetValue(prop, ...) will crash. Add a prop null check and consider propagating/handling failures from rbusValue_Init / rbusValue_SetString before setting the property value.

Copilot · 2026-04-10T12:29:45Z

src/rrdInterface.c

+rbusError_t rrd_SetHandler(rbusHandle_t handle, rbusProperty_t prop, rbusSetHandlerOptions_t* opts)
+{
+    (void)handle;
+    (void)opts;
+
+    char const* propertyName = rbusProperty_GetName(prop);
+    rbusValue_t value = rbusProperty_GetValue(prop);
+    rbusValueType_t type = rbusValue_GetType(value);
+
+    RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: Set handler called for [%s]\n", __FUNCTION__, __LINE__, propertyName);
+
+    if(strcmp(propertyName, RRD_SET_PROFILE_EVENT) == 0) {
+        if (type == RBUS_STRING) {
+            const char* str = rbusValue_GetString(value, NULL);
+            if(strlen(str) > 255) {


rrd_SetHandler() assumes prop, propertyName, value, and the string returned by rbusValue_GetString are non-null; otherwise strcmp/strlen will crash. Add explicit null checks and return RBUS_ERROR_INVALID_INPUT (or similar) when required inputs are missing.

Copilot · 2026-04-10T12:29:45Z

src/rrdInterface.c

+    // Unregister RBUS data elements for profile data provider
+    ret = rbus_unregDataElements(rrdRbusHandle, 2, profileDataElements);
+    if (ret != 0) {
+        RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS unregDataElements failed with error: %d\n", __FUNCTION__, __LINE__, ret);
+    } else {
+        RDK_LOG(RDK_LOG_DEBUG, LOG_REMDEBUG, "[%s:%d]: SUCCESS: RBUS profile data elements unregistered\n", __FUNCTION__, __LINE__);


In RRD_unsubscribe(), the success check uses ret != 0 while RRD_subscribe() compares against RBUS_ERROR_SUCCESS. For consistency and to avoid relying on numeric values, compare against RBUS_ERROR_SUCCESS here too.

Copilot · 2026-04-10T12:29:45Z

src/unittest/rrdUnitTestRunner.cpp

+    // Function should handle null input gracefully
+    // Based on implementation, this might crash or return null
+    // The test documents the current behavior


This test calls get_all_categories_json(nullptr) but does not assert any expected behavior (and the current implementation will crash on null). Once the function is fixed to handle null input, please assert the returned JSON (e.g., empty object) or assert it returns nullptr.

Suggested change

// Function should handle null input gracefully

// Based on implementation, this might crash or return null

// The test documents the current behavior

ASSERT_EQ(result, nullptr);

Copilot · 2026-04-10T12:29:45Z

src/unittest/rrdUnitTestRunner.cpp

+TEST_F(SetRbusResponseTest, HandlesValidJsonString)
+{
+    // This is difficult to test without full RBUS mock setup
+    // The function should succeed with valid inputs in a real environment
+    const char *test_json = R"({"test": "data"})";
+
+    // Without full RBUS setup, we can't fully test this
+    // But we can verify it handles the null case properly
+    rbusError_t result = set_rbus_response(nullptr, test_json);
+    // Expected behavior depends on RBUS implementation details


HandlesValidJsonString calls set_rbus_response(nullptr, test_json) but makes no assertion; with the current implementation this will crash due to a null prop. Either pass a valid mocked rbusProperty_t and assert RBUS_ERROR_SUCCESS, or explicitly assert an error code for nullptr prop after adding input validation.

Suggested change

TEST_F(SetRbusResponseTest, HandlesValidJsonString)

{

// This is difficult to test without full RBUS mock setup

// The function should succeed with valid inputs in a real environment

const char *test_json = R"({"test": "data"})";

// Without full RBUS setup, we can't fully test this

// But we can verify it handles the null case properly

rbusError_t result = set_rbus_response(nullptr, test_json);

// Expected behavior depends on RBUS implementation details

TEST_F(SetRbusResponseTest, HandlesValidJsonStringWithNullProperty)

{

const char *test_json = R"({"test": "data"})";

// The current implementation dereferences the property pointer, so when

// a null RBUS property is passed the call is expected to terminate.

// Make that behavior explicit instead of invoking it without an assertion.

EXPECT_DEATH(

{

(void)set_rbus_response(nullptr, test_json);

},

"");

Copilot · 2026-04-10T12:29:46Z

src/unittest/rrdUnitTestRunner.cpp

+TEST_F(SaveProfileCategoryTest, SaveToReadOnlyDirectory)
+{
+    // This test checks behavior when file cannot be written
+    // Create a scenario where the directory might not be writable
+    // The function should return -1 in error cases
+
+    // We can't easily test read-only scenarios in unit tests,
+    // but we can verify the function handles file creation properly
+    int result = save_profile_category();
+
+    // Should succeed in normal test environment
+    EXPECT_GE(result, -1);  // Either success (0) or expected failure (-1)
+}
+


SaveToReadOnlyDirectory doesn’t actually simulate a read-only path and the assertion EXPECT_GE(result, -1) will always pass for most return values, so it won’t catch regressions. Consider removing this test or rewriting it to deterministically force fopen() failure (e.g., by injecting a path or mocking fopen) and assert the exact error return.

Suggested change

TEST_F(SaveProfileCategoryTest, SaveToReadOnlyDirectory)

{

// This test checks behavior when file cannot be written

// Create a scenario where the directory might not be writable

// The function should return -1 in error cases

// We can't easily test read-only scenarios in unit tests,

// but we can verify the function handles file creation properly

int result = save_profile_category();

// Should succeed in normal test environment

EXPECT_GE(result, -1); // Either success (0) or expected failure (-1)

}

Abhinavpv28 added 16 commits April 8, 2026 12:15

Update rrdInterface.h

86b503b

Update rrdInterface.h

c9587f0

Update rrdInterface.c

8b712e9

Update rrdInterface.h

28ba654

Update rrdInterface.c

2a7dcba

Update rrdInterface.c

81cc501

Update rrdInterface.c

bb266ac

Update rrdInterface.c

48f1a70

Update rrdInterface.c

588db7a

Update rrdInterface.c

71e27f3

Update rrdInterface.c

4639540

Update rrdInterface.c

6f34dd2

Update rrdInterface.c

72c6e36

Update rrdInterface.c

b651cf2

Add helper functions for profile data processing

b5e0f60

Added helper functions for profile data processing.

Update rrdInterface.c

9797e9e

Abhinavpv28 requested a review from a team as a code owner April 10, 2026 09:13

Copilot AI review requested due to automatic review settings April 10, 2026 09:13

Copilot started reviewing on behalf of Abhinavpv28 April 10, 2026 09:14 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Update rrdInterface.h

394c0e3

Copilot AI review requested due to automatic review settings April 10, 2026 09:30

Copilot started reviewing on behalf of Abhinavpv28 April 10, 2026 09:32 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Abhinavpv28 added 2 commits April 10, 2026 15:16

Update Client_Mock.h

46281d3

Add mock implementations for RBusApiWrapper methods

f68941b

Copilot AI review requested due to automatic review settings April 10, 2026 09:47

Copilot started reviewing on behalf of Abhinavpv28 April 10, 2026 09:47 View session

Remove mock profile handler functions for GTEST

a3c4abe

Removed mock implementations for profile handler functions when GTEST_ENABLE is defined.

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Abhinavpv28 added 3 commits April 10, 2026 16:12

Update Client_Mock.cpp

cfbefff

Update Client_Mock.h

a9984c7

Update rrdInterface.h

2ee0aaa

Copilot AI review requested due to automatic review settings April 10, 2026 10:55

Copilot started reviewing on behalf of Abhinavpv28 April 10, 2026 10:55 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Update Makefile.am

244cb3f

Update src/rrdInterface.c

b0069c0

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings April 10, 2026 11:32

Copilot started reviewing on behalf of Abhinavpv28 April 10, 2026 11:33 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Abhinavpv28 added 2 commits April 10, 2026 17:45

Update rrdUnitTestRunner.cpp

80fa8af

Update rrdUnitTestRunner.cpp

71560b5

Copilot AI review requested due to automatic review settings April 10, 2026 12:23

Copilot started reviewing on behalf of Abhinavpv28 April 10, 2026 12:24 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

	const char *filename = "/etc/rrd/remote_debugger.json";
	const char *filename = RRD_JSON_FILE;

		if (ret != 0) {
		RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: RBUS unregDataElements failed with error: %d\n", __FUNCTION__, __LINE__, ret);

		const char *filename = "/etc/rrd/remote_debugger.json";
		long file_size;

	#define RRD_PROFILE_CATEGORY_FILE "/tmp/rrd_profile_category"
	#define RRD_PROFILE_CATEGORY_FILE "/var/run/rrd_profile_category"

		// Global storage for profile category
		char RRDProfileCategory[256] = "all";

	COMMON_CXXFLAGS = -frtti -fprofile-arcs -ftest-coverage -fpermissive
	COMMON_CXXFLAGS = -frtti -fprofile-arcs -ftest-coverage

Conversation

Abhinavpv28 commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 10, 2026

Code Coverage Summary