Skip to content

messages: remove omitempty from IsTruncated in multipart upload results #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncw merged 1 commit into from
Oct 14, 2026
Merged

messages: remove omitempty from IsTruncated in multipart upload results #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ type ListMultipartUploadsResult struct {
Prefix string `xml:"Prefix,omitempty"`

CommonPrefixes []CommonPrefix `xml:"CommonPrefixes,omitempty"`
IsTruncated bool `xml:"IsTruncated,omitempty"`
IsTruncated bool `xml:"IsTruncated"`

Uploads []ListMultipartUploadItem `xml:"Upload"`
}
Expand All @@ -421,7 +421,7 @@ type ListMultipartUploadPartsResult struct {
PartNumberMarker int `xml:"PartNumberMarker"`
NextPartNumberMarker int `xml:"NextPartNumberMarker"`
MaxParts int64 `xml:"MaxParts"`
IsTruncated bool `xml:"IsTruncated,omitempty"`
IsTruncated bool `xml:"IsTruncated"`

Parts []ListMultipartUploadPartItem `xml:"Part"`
}
Expand Down
31 changes: 31 additions & 0 deletions messages_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gofakes3
import (
"fmt"
"io"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -180,3 +181,33 @@ func TestCopyObjectResult(t *testing.T) {
t.Fatalf("unexpected XML output: %s", string(out))
}
}

func TestListMultipartUploadPartsResultIsTruncated(t *testing.T) {
res := ListMultipartUploadPartsResult{
Bucket: "mybucket",
Key: "mykey",
UploadID: "upload123",
IsTruncated: false,
}
out, err := xml.Marshal(&res)
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(out), "<IsTruncated>false</IsTruncated>") {
t.Fatalf("expected <IsTruncated>false</IsTruncated> in XML, got: %s", string(out))
}
}

func TestListMultipartUploadsResultIsTruncated(t *testing.T) {
res := ListMultipartUploadsResult{
Bucket: "mybucket",
IsTruncated: false,
}
out, err := xml.Marshal(&res)
if err != nil {
t.Fatal(err)
}
if !strings.Contains(string(out), "<IsTruncated>false</IsTruncated>") {
t.Fatalf("expected <IsTruncated>false</IsTruncated> in XML, got: %s", string(out))
}
}
Loading