Skip to content

Add implementations for all missing std::fmt traits - #141

Merged
cuviper merged 5 commits into
rayon-rs:mainfrom
msrd0:hex
Jul 24, 2026
Merged

cuviper merged 5 commits into
rayon-rs:mainfrom
msrd0:hex

Conversation

@msrd0

@msrd0 msrd0 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Closes #140

@cuviper

cuviper commented Jul 16, 2026

Copy link
Copy Markdown
Member

Can we go ahead and cover all of the stable formatting traits?
https://doc.rust-lang.org/core/fmt/index.html#traits

Debug is appropriately derived, and all the rest can forward like Display and your new *Hex impls. An internal macro may be worthwhile to avoid repetition.

@msrd0

msrd0 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@cuviper Done. I never realised there were that many traits in fmt 😅

@msrd0 msrd0 changed the title Add implementations for UpperHex and LowerHex Add implementations for all missing std::fmt traits Jul 17, 2026
Comment thread src/lib.rs
Co-authored-by: Josh Stone <cuviper@gmail.com>
@msrd0
msrd0 requested a review from cuviper July 24, 2026 13:51
@cuviper

cuviper commented Jul 24, 2026

Copy link
Copy Markdown
Member

I'll fix that MSRV failure myself.

@cuviper
cuviper force-pushed the hex branch 3 times, most recently from 02896b1 to 9fbb32e Compare July 24, 2026 17:37

@cuviper cuviper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cuviper
cuviper added this pull request to the merge queue Jul 24, 2026
Merged via the queue into rayon-rs:main with commit e514cb1 Jul 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Implement UpperHex / LowerHex

2 participants