fix: harmoniser l’affichage brut/filtré en µV - #278
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
raveriss
marked this pull request as ready for review
February 5, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
VOLTS_TO_MICROVOLTS = 1e6et utilisation centralisée de cette constante dansscripts/visualize_raw_filtered.pypour convertir les données affichées de volts en µV.raw.get_data()etfiltered.get_data()avant tracé pour garantir une unité homogène sur les deux axes."Amplitude (µV)"et"Amplitude filtrée (µV)"dansscripts/visualize_raw_filtered.py.tests/test_visualize_raw_filtered.pypour valider la conversion (attendus multipliés par1e6) et les nouveaux labels.Testing
poetry run pytest tests/test_visualize_raw_filtered.py -q— OK (20 passed).poetry run pytest -q— OK (577 passed, 22 warnings).poetry run pre-commit run --all-files,poetry run black --check .,poetry run isort --check-only .,poetry run ruff check .,poetry run mypy src scripts tests— OK (all passed).poetry run pip-audit --progress-spinner=off(initial pip version warning fixed by upgrading pip then re-run — final audit OK/known-skip for local package),make cov— OK (coverage report produced; total coverage 90% as reported).Codex Task