Remove __array__() method#141
Merged
Merged
Conversation
Instead, users should reshape their Numpy arrays.
mwtoews
approved these changes
Mar 1, 2026
mwtoews
left a comment
Contributor
There was a problem hiding this comment.
Sure, no big loss removing __array__. It's just a convenience when comparing against NumPy functions, as retained here in the tests.
This revert keeps the flat (dimensionless) structure the same as previous versions. I just have a suggestion to keep a test for the expected behavior of np.array(tfm) (i.e. that it doesn't return a 3x3 matrix).
| ar = np.array(tfm) | ||
| assert ar.shape == (3, 3) | ||
| assert ar.dtype == np.float64 | ||
| testing.assert_array_equal(ar, expected) |
Contributor
There was a problem hiding this comment.
Perhaps retain a simple test that describes what's expected of numpy, specifically something like this:
def test_array():
six_args = (np.arange(6) + 1) / 10
tfm = Affine(*six_args)
ar = np.array(tfm)
assert ar.shape == (9,)
testing.assert_array_equal(ar, np.concat([six_args, (0, 0, 1)]))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package shouldn't depend on Numpy. Instead, users should reshape their Numpy arrays created from Affine instances.
My second favorite approach would be to implement a
.2dattribute (or a better name) so that users would do this:np.array(Affine().2d).