This repository was archived by the owner on Jun 3, 2026. It is now read-only.
Discard dispatch API response body#3
Merged
jameslamb merged 1 commit intoDec 19, 2025
Conversation
gforsyth
approved these changes
Dec 19, 2025
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
I'll let others take a look, too, but this seems like a reasonable fix, will protect us from future changes, and isn't overly invasive.
jameslamb
approved these changes
Dec 19, 2025
jameslamb
left a comment
jameslamb
left a comment
Member
There was a problem hiding this comment.
I agree, this looks like a relatively future-proof fix.
rockhowse
self-requested a review
December 19, 2025 16:53
rockhowse
approved these changes
Dec 19, 2025
rockhowse
left a comment
rockhowse
left a comment
There was a problem hiding this comment.
After reviewing the following
I am ok with this solution if it unblocks nightlies and CCCL 3.2 work.
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting convictional#109 to our fork.
Resolves issues discussed in https://github.com/orgs/community/discussions/9752#discussioncomment-15294117.
That discussion mentions the API break will be rolled back but GitHub may still make this change in January 2026. This change should make our action work either way, in my understanding.